Removes all hardcoded overmap_connection_id references #72725
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Hardcoded references bad
Allows mods/regions to have different connections for inter city vs intra city vs normal specials road connections, the former of which was impossible before while the latter required redefining every special to change it's connection
Is also useful for debugging city/inter city roads
Also fixes #72532 bc it's just a 1 line oversight and in the same file
Describe the solution
Adds a new region setting category for the connections with documentation explaining their uses and requirements
Replacing the intra city connections doesn't work perfectly because there's a few hardcoded references to the road oter so for example you can end up with two parallel adjacent roads, will look at making this more seamless in a future PR.
Describe alternatives you've considered
I were going to have them default in region_settings.h and make the category optional so it needn't be defined anywhere unless being overridden but that kind of defeats the purpose of removing the references
Testing
Used the test mod below to check both the new settings and overlay work correctly
Additional context
This could be used to yeet the SIDEWALK flag