Allow migrating from deleted variants #72717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
[C++]
On loading a variant that is not a possible variant for the given item, search for a migration from that item with the variant that was loaded, and apply that migration if relevant.
The variant moved from one shotgun to another, so add a migration. In b9c4092
anothersimulacrum
force-pushed
the
migrate-from-dead-variants
branch
from
20b2dd4 to
f3ad0e9
Compare
github-actions
bot
added
the
BasicBuildPassed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bugfixes "Fix migrating from item variants when the variant has been deleted"
Purpose of change
Fixes #72607
Fixes #72602
Describe the solution
On loading a variant that is not a possible variant from the given item, try to search for a migration from that item with the variant that was loaded, and apply that migration if relevant.
Moved some code around so as to not duplicate it, which makes up most of the diff.
Also added a migration to fix #72602
Testing
Follow steps in #72607.