Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add map_id condition for EoC #72661

Merged
merged 1 commit into from
Mar 28, 2024
Merged

Conversation

GuardianDll
Copy link
Member

Summary

None

Purpose of change

Another thing, tangentially requested by Karol for their mod, but would be useful anyway

Describe the solution

add map_terrain_id and map_furniture_id fields, that check is the coordinates they got contain specific terrain or not

Testing

Compiled, run EoC that is added in documentation
image

Additional context

The best approach would probably be using it in combination with foreach effect, so you just have a list of terrain to check and that's it

@github-actions github-actions bot added <Documentation> Design documents, internal info, guides and help. [C++] Changes (can be) made in C++. Previously named `Code` [Markdown] Markdown issues and PRs EOC: Effects On Condition Anything concerning Effects On Condition labels Mar 27, 2024
@RedMisao
Copy link
Contributor

omg thank you

@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Mar 27, 2024
@Maleclypse Maleclypse merged commit 71c936f into CleverRaven:master Mar 28, 2024
23 of 28 checks passed
@GuardianDll GuardianDll deleted the map_id branch March 28, 2024 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` <Documentation> Design documents, internal info, guides and help. EOC: Effects On Condition Anything concerning Effects On Condition json-styled JSON lint passed, label assigned by github actions [Markdown] Markdown issues and PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants