-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes Naming of CZ 12-round Magazine, and Adjusts the Descriptions of Reloaded 5.7mm Ammunition #72653
Conversation
…s in such amounts has never been seen before in heven, nor in earth, I tell you.
The reason the name of the magazine is different because during my research into CZ 75 mags, I'd discovered that 12-round magazines for the pistol were not at all common. I suggested, then, to make it a 16-rounder, which is far more common IRL. I'm thinking maybe @ANickelN forgot to adjust the capacity after renaming the mag. It should, by all accounts, be a 16-round mag, with the appropriate capacity, since it was modelled as such after the rework. |
Co-authored-by: Tonkatsu <[email protected]>
Co-authored-by: Tonkatsu <[email protected]>
Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details. Click to expand
This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to |
Thank you for bringing this to my attention. I must admit, I just followed what the ID told me. I’ll hammer out a quick migration to a 16-round magazine. I could always just change the name, description, and cartridge amount, but leaving the ID there makes me irritated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there should be a comma after either "recoil" or "armor penetration" in the last sentence of the black powder reload description.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered. |
Summary
None
Purpose of change
It was pointed out in the discord that there was trouble within the wonderful lands of our guns: an unrest unimagined, an error in the matrix, an anomaly in the force.
The CZ 12-round magazine has an ID that describes it as holding 12 rounds, and, in game, it does only hold 12 rounds. However, the name and description indicated that it holds 16 rounds.
The descriptions for reloaded 5.7x28mm ammo, whether black powder or normally reloaded, were rather strange, as unlike most other calibres, they provided no description for the effects that the reloading process has on the performance of the cartridge. In addition, labelling something as being loaded with an FMJ bullet while it explicitly lacks any FMJ characteristic is a tad misleading.
Describe the solution
Fixes these errors and returns peace and stability to the CDDA gun kingdom.
Describe alternatives you've considered
Closing my eyes and believing very, very hard that these issues don’t exist, that no issues exist, and that I am a pony free of these worries.
Testing
They’re simple string changes. If I manage to screw something up, I will proudly pin a medal to my mug.
Additional context