Fix flaky drying test #72650
Merged
Fix flaky drying test #72650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Code: Tests
|
BIG MARGINS until we get around to a better solution is fine. |
|
@Venera3 It looks like I caught another random failure even after this. Am I just the unlucky lottery winner? https://github.com/CleverRaven/Cataclysm-DDA/actions/runs/8473598830/job/23218304344#step:17:83 |
|
Imma just go with "seems so unless it happens twice". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Fix #72631
Describe the solution
Gave base_dry a slightly larger margin, uncouple the high/low rate target from the current base dry.
Describe alternatives you've considered
Move drying over to a less random system than
roll the remainder of 0,004 every turn, but that's work.Testing
Ran the test 500,000 times, passed.
Additional context