Brewing density fixes #72640
Closed
Brewing density fixes #72640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Distilling is a separate process (and recipe), so no volume loss due to evaporation should occur here.
github-actions
bot
added
[JSON]
|
Did you mean to close this? |
Yes. It is superseded by #72641 It turned out that correcting densities has triggered "known bad density" tests to fail because now unfermented vinegar and young yeast need to be removed from the list. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bugfixes "Correct Density for Some Brewing Fluids"
Purpose of change
Some densities of brewing liquids were wrong because the JSON entries still had their "charges" fields set to something other than 1 resulting in wrong calculations.
Describe the solution
I've set the "charges" fields to 1 correcting "weight" and/or "volume" fields if needed.
Describe alternatives you've considered
I could return charges and recalculate "weight"/"volume" fields instead, but I was told that would not be the appropriate solution as we are trying to discard the "charges" field for good.
Testing
Tested recipes in-game. They seem to produce the correct yield unit-wise and densities are OK.
Additional context
None.