Arsonist should buy Merch at full value #72637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
NPC / Factions
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
data/json/npcs/refugee_center/surface_visitors/NPC_arsonist.json
Outdated
Show resolved
Hide resolved
github-actions
bot
added
the
astyled
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions
bot
added
json-styled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Balance "Arsonist should buy Merch at full value"
Purpose of change
The arsonist in the refugee center was buying Merch from the player at a discount (determined by social skill and intelligence) because the arsonist is technically not part of the free_merchants. I think she should value Merch at full price because she lives in the refugee center and regularly trades with free_merchants.
Describe the solution
Add shopkeeper_price_rules to NC_ARSONIST
Describe alternatives you've considered
Set the faction of arsonist to free_merchants - I did not do this because I do not know what NPC faction affects besides trading prices
Testing