Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tune up some misc oter type spawn ratios #72601

Merged
merged 1 commit into from
Mar 26, 2024
Merged

Conversation

kevingranade
Copy link
Member

Basically make several should-be-rare variants rare. Also make gun shops overall slightly rarer.

Summary

None

Purpose of change

While looking at item demographics, I noticed that suicide vignettes were equally weighted with other house/basement variants, making them way more common than they should be.
In a similar but less extreme vein, hunting stores were way too common, as are gun shops in general. The problem seems to be that as variants are being added people haven't been diluting spawns, just adding new variants with the same weighting, meaning the overall share of gun stores kept increasing.

Describe the solution

Drop the weights, by 25% for gun stores, 50-75% for hunting stores and banks, and about 90% for suicide vignettes.

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Mar 24, 2024
Basically make several should-be-rare variants rare.
Also make gun shops overall slightly rarer.
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Mar 26, 2024
@dseguin dseguin merged commit 08674dc into master Mar 26, 2024
24 checks passed
@kevingranade kevingranade deleted the rarer-gun-locations branch April 15, 2024 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Map / Mapgen Overmap, Mapgen, Map extras, Map display
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants