Kill off ammo vending machines

[kevingranade]

Summary

None

Purpose of change

"Ammo vending machines"

Describe the solution

Remove.

[PatrikLundell]

It seems this just removes the ability to get (some of the?) ammo from gun stores, without spawning replacement ammo elsewhere?

I'm fine with the removal of the machines, but the ammo ought to be spawned by other means.

If it's considered too much work to locate all the places where these machines were placed and distribute ammo in them, I'd rather use a cheap replacement of providing some, preferably locked, furniture with ammo in it in the palette.

[harakka]

Afaik this is happening as part of investigating where and how much ammo currently spawns and fixing it to match reality. The goal isn't to preserve the current numbers.

[PatrikLundell]

If that's a thought out move, then that's fine. It looked like an extension of the vending machine transformation to me, though, which is why I voiced my concern.

[kevingranade]

A cursory glance at the item group shows that it's only spawning ammo that spans in extremely large quantities elsewhere, so there's certainly no risk of this change making anything unavailable.

If you're talking about absolute quantities of ammo spawned, as harakka says that's currently in a state of total nonsense and this is part of an effort to fix it.

This actually predates the recent look at vending machine stuff and i just had it sitting on a local branch for months.

[Rasengetsu]

As suspected by Patrik, this actually did remove all ammo from the gunstore variant that used ammo vending machines since all the ammo spawns of this variant were tied to the vending machines.
I would recommend adding safes that follow the same spawn rules as the other unlooted gunstore variants as it makes no sense to have an unlooted gunstore with many guns and a large amount of empty magazines but no bullets for them. Anyone who would loot the ammo would also take the magazines and in many cases the guns too.

[Fris0uman]

You should open an issue about if it's not done already. Closed PR are not the correct place to track bugs