Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MoM] Allow people to ask Rubik about the alien flora scattered around #72581

Merged
merged 9 commits into from
May 23, 2024

Conversation

Standing-Storm
Copy link
Contributor

@Standing-Storm Standing-Storm commented Mar 24, 2024

Summary

Mods "[MoM] Allow people to ask Rubik about the alien flora scattered around"

Purpose of change

Getting back into adding dialogue, wanted to let people ask Rubik about the patches of alien flora.

Describe the solution

Add some dialogue options. They don't show up until a bit of time has passed, to make sure that the player has definitely seen weird alien trees or moss before they can ask about them.

Describe alternatives you've considered

Testing

Topics appear and lead to appropriate places.

Additional context

@Standing-Storm Standing-Storm marked this pull request as draft March 24, 2024 04:46
@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Mods: Mind Over Matter astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Mar 24, 2024
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

@github-actions github-actions bot added the stale Closed for lack of activity, but still valid. label Apr 24, 2024
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label May 10, 2024
Copy link
Contributor

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • Aye, mayhap, but more'll dribble through the wobbles. You can't athwart all o' the bridges. If'n you light each and every, you're only one against many. 'Twould be no point. The road only goes one way.
  • Sure, the plants o' otherworlds. Them as comes from the wibbles. Like as this'n's seen, 'tis all down 'n down, an I'm ken.
  • Til the green and brown be yellowred and blue afore it be to grey and black. 'Tis the course.

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

Hints for adding a new word to the dictionary
  • If the word is normally in all lowercase, such as the noun word or the verb does, add it in its lower-case form; if the word is a proper noun, such as the surname George, add it in its initial-caps form; if the word is an acronym or has special letter case, such as the acronym CDDA or the unit mW, add it by preserving the case of all the letters. A word in the dictionary will also match its initial-caps form (if the word is in all lowercase) and all-uppercase form, so a word should be added to the dictionary in its normal letter case even if used in a different letter case in a sentence.
  • For a word to be added to the dictionary, it should either be a real, properly-spelled modern American English word, a foreign loan word (including romanized foreign names), or a foreign or made-up word that is used consistently and commonly enough in the game. Intentional misspelling (including eye dialect) of a word should not be added unless it has become a common terminology in the game, because while someone may have a legitimate use for it, another person may spell it that way accidentally.

@Standing-Storm Standing-Storm marked this pull request as ready for review May 12, 2024 03:54
@Standing-Storm
Copy link
Contributor Author

@I-am-Erk Did my best, but if you have a moment to look it over, I'd be thankful.

@github-actions github-actions bot removed the stale Closed for lack of activity, but still valid. label May 13, 2024
@github-actions github-actions bot removed the BasicBuildPassed This PR builds correctly, label assigned by github actions label May 15, 2024
@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions and removed json-styled JSON lint passed, label assigned by github actions labels May 19, 2024
@dseguin dseguin merged commit 9e4e759 into CleverRaven:master May 23, 2024
20 of 24 checks passed
@Standing-Storm Standing-Storm deleted the ask-rubik branch May 23, 2024 19:53
@I-am-Erk
Copy link
Member

Sorry I missed the ping. I'm pretty behind on some dialogue reviews but I'll take a look and if something needs fixing I'll try to pr it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: Mind Over Matter Mods Issues related to mods or modding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants