-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allows setting fixed special scoped parameters for start locations #72558
Conversation
As an in repo use case of this Sorry to request some extra work from you but I think that will both demonstrate a usecase and close a stable blocker. |
Backporting this for that purpose doesn't seem like the best solution bc it would require a pretty hefty parameterisation of mansion_boarded into the normal mansions (likely several 1000 line changes) Thanks for pointing out the mansion start though, I'll still do the parameterisation at some point down the road to cut down on repeated maps and make future adjustments easier as well as adding variety by allowing the start in all the different mansion layouts but I don't want to do that rn (I also want to give the mansions driveways and parking at some point) |
Opened the mansion feral PR #72695 |
Is there any issue with using a draft PR as a use case? I'd of put this in with the evac centre PR but I thought it made more sense to separate them |
Summary
None
Purpose of change
Closes #72479
Needed for #72561 and #72809
Describe the solution
You can set singular or multiple parameters to singular values which then override those calculated normally when the mapdata is initialised, so you don't have to set every parameter.
You can also use this to set a parameter to a 0 weight value for it to be start location only.
set_parameters somewhat cargo cults overmap_ui's set_special_args used for debug setting parameters
Describe alternatives you've considered
The bool being stored in overmap_buffer is pretty gross but I couldn't see how to easily scope it otherwise
It still calcs the overridden parameters which is suboptimal but I didn't fancy attacking the function that spits them all out together
If I or someone else gets around to doing #72529 the functions will probably want moving to overmap_special but I didn't fancy trying to scope that for this
Testing
Tested with #72561
Additional context