Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ Xedra Evolved ] Paraclesian's shouldn't have drivers license #72493

Merged
merged 21 commits into from
Sep 29, 2024
Merged

[ Xedra Evolved ] Paraclesian's shouldn't have drivers license #72493

merged 21 commits into from
Sep 29, 2024

Conversation

Maleclypse
Copy link
Member

@Maleclypse Maleclypse commented Mar 19, 2024 •
edited
Loading

Summary

Mods "Prevent Paraclesians from being born with a drivers license"

Purpose of change

Limits Paraclesian hobbies to the Paraclesian birth hobby granting deduction.

Describe the solution

Use the hobbies field in professions.

Describe alternatives you've considered

None

Testing

Seems to be working

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies Mods: Xedra Evolved Anything to do with Xedra Evolved labels Mar 19, 2024
@github-actions github-actions bot added the astyled astyled PR, label is assigned by github actions label Mar 19, 2024
@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Mar 19, 2024
@github-actions github-actions bot removed the BasicBuildPassed This PR builds correctly, label assigned by github actions label Mar 21, 2024
@Maleclypse
Copy link
Member Author

Note to self: Hommullus should have access to Birthmark hobbies that block other birthmarks but grant a special ability of minor usage. The Key, should unlock a door once a day.

@Maleclypse @github-actions
Paraclesian's shouldn't have drivers license
d7744eb 
Update data/mods/Xedra_Evolved/player/hobbies.json

Update hobbies.json

Arvore start

Co-Authored-By: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions GitHub Actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

@github-actions github-actions bot added the stale Closed for lack of activity, but still valid. label Apr 21, 2024
@Maleclypse Maleclypse removed the stale Closed for lack of activity, but still valid. label Apr 25, 2024
Fris0uman
Fris0uman reviewed May 17, 2024
View reviewed changes
Copy link
Contributor

@Fris0uman Fris0uman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are failing on missing traits

data/mods/Xedra_Evolved/player/hobbies.json Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

@github-actions github-actions bot added the stale Closed for lack of activity, but still valid. label Jun 16, 2024
@github-actions github-actions bot closed this Jul 16, 2024
@Maleclypse Maleclypse reopened this Sep 9, 2024
@Maleclypse Maleclypse removed the stale Closed for lack of activity, but still valid. label Sep 10, 2024
@github-actions github-actions bot removed the json-styled JSON lint passed, label assigned by github actions label Sep 10, 2024
@Maleclypse @github-actions
Update data/mods/Xedra_Evolved/mutations/paraclesians/ierde_eocs.json
3113eb4 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot added the json-styled JSON lint passed, label assigned by github actions label Sep 10, 2024
@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions and removed json-styled JSON lint passed, label assigned by github actions labels Sep 11, 2024
@github-actions github-actions bot removed the json-styled JSON lint passed, label assigned by github actions label Sep 11, 2024
Maleclypse and others added 2 commits September 11, 2024 09:17
@Maleclypse @github-actions
Update data/mods/Xedra_Evolved/mutations/paraclesians/ierde_eocs.json
e8d4a36 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@Maleclypse @github-actions
Update data/mods/Xedra_Evolved/mutations/paraclesians/ierde_eocs.json
68e0eef 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot added the json-styled JSON lint passed, label assigned by github actions label Sep 11, 2024
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Sep 15, 2024
@Maleclypse
Copy link
Member Author

Need to add the spell still.

@github-actions github-actions bot added the Mechanics: Enchantments / Spells Enchantments and spells label Sep 19, 2024
@dseguin dseguin merged commit 879a471 into CleverRaven:master Sep 29, 2024
20 of 24 checks passed
@Standing-Storm Standing-Storm mentioned this pull request Oct 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@Fris0uman Fris0uman Fris0uman left review comments

Assignees
No one assigned
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions EOC: Effects On Condition Anything concerning Effects On Condition [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mechanics: Enchantments / Spells Enchantments and spells Mods: Xedra Evolved Anything to do with Xedra Evolved Mods Issues related to mods or modding Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Maleclypse @Fris0uman @dseguin