Fix refugee's teamster dialogue which doesn't roll directions anymore #72437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `time_since` math function (?) returns -1 for undefined variables, as described in docs[1]. This creates a scenario which the second clause of '< 2 d' to always match, and directions are never actually rolled. This patch fixes that by merging both rolling direction cases in a single conditional cause, and the fallback is the do-nothing case.
github-actions
bot
added
NPC / Factions
andrei8l
reviewed
Mar 16, 2024
data/json/npcs/refugee_center/surface_staff/NPC_free_merchant_teamster.json
Outdated
Show resolved
Hide resolved
…teamster.json Co-authored-by: andrei <[email protected]>
carlarctg
reviewed
Mar 17, 2024
data/json/npcs/refugee_center/surface_staff/NPC_free_merchant_teamster.json
Outdated
Show resolved
Hide resolved
…teamster.json Co-authored-by: carlarctg <[email protected]>
github-actions
bot
added
json-styled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bugfixes "Refugee's teamster dialogue which doesn't roll directions anymore"
Purpose of change
Fix dialogue to actually roll directions.
Describe the solution
The
time_sincemath function (?) returns -1 for undefined variables, as described in docs[1]. This creates a scenario which the second clause of '< 2 d' to always match, and directions are never actually rolled.This patch fixes that by merging both rolling direction cases in a single conditional cause, and the fallback is the do-nothing case.
Describe alternatives you've considered
Using a timer EOC similar to how Hub 01 uses to roll bar visitors.
Testing
I ran the game with this patch + extra annotation to each dialogue to know which one was picked by the engine. Dialogue works as expected.
Additional context