Bugfix Biokinetic learning conditions in biokinesis.json #72418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix Incorrect Spell Tag "biokin_biokin_adrenaline"
github-actions
bot
added
[JSON]
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Auto-requesting reviews from non-collaborators: @Standing-Storm
github-actions
bot
added
<Bugfix>
Standing-Storm
approved these changes
Mar 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bugfixes "Bugfix Biokinetic learning conditions in biokinesis.json"
Purpose of change
PR #70305 was the first of the PRs that gave power learning more flexibility in the Mind over Matter mod. While a positive change overall, this PR seems to have come with a few spell id mistakes, specifically with 3 references to the "biokin_biokin_adrenaline" spell rather than the "biokin_adrenaline" spell. This PR corrects these ids, allowing Dash, Enhanced Reflexes, and Hurricane Blows to be learned with appropriate Adrenaline Trigger levels.
Describe the solution
Change "biokin_biokin_adrenaline" to "biokin_adrenaline" in the relevant file.
Describe alternatives you've considered
N/A
Testing
Made changes in my own build. Created a new world & new character with Physical Enhancement 10 & Adrenaline Trigger 10. Practicing Physical Enhancement eventually triggered the learning event for Dash.
Additional context
N/A