Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limbify drying rate again #72406

Merged
merged 3 commits into from
Mar 22, 2024
Merged

Limbify drying rate again #72406

merged 3 commits into from
Mar 22, 2024

Conversation

Venera3
Copy link
Member

@Venera3 Venera3 commented Mar 15, 2024 •
edited
Loading

Summary

Features "Limbify limb drying rate"

Purpose of change

The sweating/perspiration rework slightly broke drying_increment, this fixes that.

Describe the solution

Rename/rework it as drying_rate, acting like a multiplier on the drying rate of the limb.
Added a bunch of unit tests to protect it from grubby lil' coders in the future.

Describe alternatives you've considered

Bundle every sweaty/drenchy/tempy limb stuff into one PR, but I really need to finish bird arms.

Testing

Tests test sufficiently. Dryier limbs dry noticeably faster.

Additional context

@github-actions github-actions bot added <Documentation> Design documents, internal info, guides and help. Code: Tests Measurement, self-control, statistics, balancing. [C++] Changes (can be) made in C++. Previously named `Code` [Markdown] Markdown issues and PRs Limbs Limbs, mutable limbs, and code related to them. <Enhancement / Feature> New features, or enhancements on existing json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Mar 15, 2024
@github-actions github-actions bot added the [JSON] Changes (can be) made in JSON label Mar 15, 2024
I-am-Erk
I-am-Erk reviewed Mar 22, 2024
View reviewed changes
doc/JSON_INFO.md Outdated Show resolved Hide resolved
@I-am-Erk I-am-Erk merged commit d5a44a1 into CleverRaven:master Mar 22, 2024
22 of 27 checks passed
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Mar 23, 2024
@hexagonrecursion hexagonrecursion mentioned this pull request Mar 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@I-am-Erk I-am-Erk I-am-Erk left review comments

Assignees
No one assigned
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` Code: Tests Measurement, self-control, statistics, balancing. <Documentation> Design documents, internal info, guides and help. <Enhancement / Feature> New features, or enhancements on existing [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Limbs Limbs, mutable limbs, and code related to them. [Markdown] Markdown issues and PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Venera3 @I-am-Erk