Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new profession: Mixed Martial Artist #72395

Merged
merged 3 commits into from
Mar 25, 2024
Merged

Added new profession: Mixed Martial Artist #72395

merged 3 commits into from
Mar 25, 2024

Conversation

Hymore246
Copy link
Contributor

Adds Mixed Martial Artist profession

Summary

Content "Adds new profession: Mixed Martial Artist"

Purpose of change

Adds a profession that can start with multiple combat styles

Describe the solution

Adds Mixed Martial Artist as a profession. Starting equipment is minimal and has skill level 3 in Unarmed and Melee. The main gimmick of the profession is that they start with any 3 of the following martial art styles:

  • Boxing
  • Judo
  • Karate
  • Kickboxing
  • Muay Thai
  • Pankration
  • Taekwondo
  • Wing Chun

Describe alternatives you've considered

The martial arts used by the profession the most common styles I've found used by actual MMA fighters. Pankration is a stand in for Wrestling. While the actual training for each MMA fighter can differ greatly, using common styles is the simplest way to add the style to the game. The player can still add other styles to their character through other methods.

Testing

  1. Create a new character and select the Mixed Martial Artist profession.
  2. Upon finishing character creation, select 3 starting styles of your choice.
  3. After loading into the world, verify that all selected styles are known by the character.
  4. (Optional) Beat up zeds with chosen styles.

Additional context

The main reason for adding this profession is to demonstrate how a profession can start with more than one style from a given list. Currently, professions either start with a specific style (Fencer) or pick a single style (Martial Artist) from a list.

I may consider adding another profession that starts with more than one specific to demonstrate that function in character creation.

Adds Mixed Martial Artist profession
@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies labels Mar 14, 2024
data/json/professions.json Outdated Show resolved Hide resolved
data/json/professions.json Outdated Show resolved Hide resolved
@github-actions github-actions bot added the astyled astyled PR, label is assigned by github actions label Mar 14, 2024
Hymore246 and others added 2 commits March 14, 2024 23:15
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot added the json-styled JSON lint passed, label assigned by github actions label Mar 15, 2024
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Mar 24, 2024
@Maleclypse Maleclypse merged commit 2a21f9f into CleverRaven:master Mar 25, 2024
19 of 24 checks passed
@adamkad1
Copy link
Contributor

Can we get that on a background too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants