Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Magiclysm] Technomancer Binoculars Spell #72251

Merged
merged 18 commits into from
Mar 13, 2024

Conversation

rty275
Copy link
Contributor

@rty275 rty275 commented Mar 8, 2024

Summary

Mods "Adds Technomancer binoculars spell"

Purpose of change

Giving technomancers some magitechnical means of replacing binoculars temporarily.

Describe the solution

After my previous attempt that was rejected for reasonable reasons, Maleclypse suggested a technomancer spell that gave better-than-binoculars overmap tile sight. This does that!

I initially gave it one tile of sight per level of the spell but that was very powerful and while the difficulty and scarcity of the components might have balanced that, I didn't want to front-load the functionality so that there was no reason to level it. The plus version does give one tile per level, but given how difficult it'll be to level since it's impossible to study as a book and has scarce components, I figured that'd be fair.

The components are as scarce as they are to make this something you have to actually be choosy about when to use. The spell lasts a long time so it holds up to a good few hours of exploration, without allowing you to set it and forget it every day. That's also why I decided against a permanent item made by a craft instead of a spell or something instead, along with the fact that I wanted it to scale in potency with spell level. I also thought the idea of tools being required for a technomancer spell just made sense, hence the chisel and mana focus requirement, since this is themed almost like a crafting recipe for a temporary item.

Describe alternatives you've considered

Not adding this? Giving it less restrictive components? Making it an actual crafting recipe for a permanent item instead? I think I've addressed those thoughts above.

Testing

Both spells cast properly with required components, lens item spawned properly, sight range varied based on level of spell correctly, scroll and spellbook appeared in tests of the relevant item groups properly. Can't think of anything else to test here?

Additional context

This is my second attempt at formulating a functional and thematic technomancer spell for some sort of overmap sight ability. I recognize the first attempt was not suitably interesting and distinct to make it make sense as an actual spell rather than just as my desires for mapping, and I hope I've fixed those problems with this attempt, but I can always edit it further if needed. Or stop trying to push the idea if that's desired too, I want to be clear that while I like and want this idea, I'm not trying to force it where it doesn't fit.

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Spawn Creatures, items, vehicles, locations appearing on map Mods: Magiclysm Anything to do with the Magiclysm mod Mechanics: Enchantments / Spells Enchantments and spells labels Mar 8, 2024
@github-actions github-actions bot requested a review from KorGgenT March 8, 2024 19:48
data/mods/Magiclysm/items/item_enchants.json Outdated Show resolved Hide resolved
data/mods/Magiclysm/items/spellbooks.json Outdated Show resolved Hide resolved
data/mods/Magiclysm/items/spellbooks.json Outdated Show resolved Hide resolved
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Mar 8, 2024
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Mar 8, 2024
@Maleclypse Maleclypse merged commit 8081adf into CleverRaven:master Mar 13, 2024
19 of 24 checks passed
@Maleclypse
Copy link
Member

This is great! I look forward to your further contributions!

@rty275 rty275 deleted the technomancer-far-sight branch March 13, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mechanics: Enchantments / Spells Enchantments and spells Mods: Magiclysm Anything to do with the Magiclysm mod Mods Issues related to mods or modding Spawn Creatures, items, vehicles, locations appearing on map
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants