Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed Bore mod location from guns that don't use it, standar-ished mechanism slots to 2. #72246

Merged
merged 7 commits into from
Mar 28, 2024

Conversation

carlarctg
Copy link
Contributor

@carlarctg carlarctg commented Mar 8, 2024

Summary

Content "Removed Magazine & Bore gunmod location from guns that don't use it"

Purpose of change

Seeing the "bore" location on every gun is an eyesore, especially when you're being a nerd and overly customizing your gun. But it applies outside of that as well. It's also just entirely unnecessary and too confusing for new players.

Mechanism slots were all over the place. 4 looked ungainly in the examine screen and was complete overkill, some guns had 2, others had 1, most had 4.. setting it to 2 is enough for firearm waterproofing and match trigger, which are the only unintegrated mechanism mods you're actually going to see ingame, and you probably shouldn't fit too many things inside the firing mechanism of a gun. I kept the pipe rifles and similar at 1 mechanism slot because that seems reasonable to me.

Removed magazine gunmod slot as it was unused

Describe the solution

Removing the bore location entirely from all guns that don't have a conversion kit, including base types.

Setting mechanism slots to 2, except for some handmade guns which have 1.

Describe alternatives you've considered

None!

Testing

Spawned in, found a soldier with a gun, saw that the bore slot was still there with a conv. kit. Spawned a gun & kit and made sure it fit.

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Code: Tests Measurement, self-control, statistics, balancing. Items: Ammo / Guns Ammunition for all kinds of weapons and these weapons themselves Mods: Magiclysm Anything to do with the Magiclysm mod Mods: Aftershock Anything to do with the Aftershock mod Mods: Generic Guns Anything to do with Generic Guns Items: Archery Bows, crossbows, arrows, bolts Items: Containers Things that hold other things Mods: Xedra Evolved Anything to do with Xedra Evolved labels Mar 8, 2024
@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Mar 8, 2024
@John-Candlebury
Copy link
Member

Aftershock has bore mod "id": "afs_shotgun_gauss" that can be applied to any shotgun. Can you please move that to the barrel slot and ensure that all aftershock shotguns can take barrels mod while at it.

@carlarctg
Copy link
Contributor Author

Aftershock has bore mod "id": "afs_shotgun_gauss" that can be applied to any shotgun. Can you please move that to the barrel slot and ensure that all aftershock shotguns can take barrels mod while at it.

Any reason it can't be made a mechanism mod instead?

@John-Candlebury
Copy link
Member

Any reason it can't be made a mechanism mod instead?

Yes, guns only have 1 barrel slot, just as they used to have a single bore slot. Please move it there.

@carlarctg
Copy link
Contributor Author

Wait magazine is also a totally unused gunmod location. BRUH

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Mar 11, 2024
@Maleclypse Maleclypse merged commit fd2687a into CleverRaven:master Mar 28, 2024
20 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Code: Tests Measurement, self-control, statistics, balancing. Items: Ammo / Guns Ammunition for all kinds of weapons and these weapons themselves Items: Archery Bows, crossbows, arrows, bolts Items: Containers Things that hold other things [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: Aftershock Anything to do with the Aftershock mod Mods: Generic Guns Anything to do with Generic Guns Mods: Magiclysm Anything to do with the Magiclysm mod Mods: Xedra Evolved Anything to do with Xedra Evolved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants