Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port some mutation/cbm specific fields to enchantments, part 3 #72173

Merged
merged 50 commits into from
Mar 9, 2024
Merged

Port some mutation/cbm specific fields to enchantments, part 3 #72173

merged 50 commits into from
Mar 9, 2024

Conversation

GuardianDll
Copy link
Member

Summary

None

Purpose of change

Continuation of #72034

Describe the solution

Still porting strictly mutation/cbm effects to enchantment system

Testing

TBD

GuardianDll and others added 20 commits March 2, 2024 15:29
@GuardianDll
remove weakness_to_water, add WEAKNESS_TO_WATER as replacement, fix i…
58a8964 
…t not working with negative values
@GuardianDll
remove fat_to_max_hp, make FAT_TO_MAX_HP as replacement
8344b46
@GuardianDll
remove healthy_rate, create HEALTHY_RATE as a replacement
00af564
@GuardianDll
remove scent_mask, adds SCENT_MASK to replace it
930dbfd
@GuardianDll
remove consume_time_modifier, make CONSUME_TIME_MOD as replacement
af07586
@GuardianDll
remove reading_speed_multiplier
270fd34
@GuardianDll
remove overmap_sight and overmap_multiplier
5cd0e93
@GuardianDll
remove sweat_multiplier, add SWEAT_MULTIPLIER as replacement
e8a60db
@GuardianDll
remove vomit_multiplier
1077f96
@GuardianDll
remove stamina_regen_modifier, make STAMINA_REGEN_MOD as replacement
c8a5d95
@GuardianDll
remove fatigue_regen_modifier, make FATIGUE_REGEN as replacement
284445a
@GuardianDll
remove fatigue_modifier
4ebe7d0
@GuardianDll
remove noise_modifier
ca35387
@GuardianDll
remove crafting_speed_multiplier
7fd37d9
@GuardianDll
remove casting_time_multiplier
f89fea7
@GuardianDll
remove bionic_mana_penalty
49e9094
@GuardianDll
remove mana_regen_multiplier
af0d154
@GuardianDll
remove mana_multiplier
e0d0653
@GuardianDll
remove mana_modifier
9954d0c
@GuardianDll
refine water damage to allow float values, make it tick once per seco…
ee30d78 
…nd instead of once per minute
@github-actions github-actions bot added <Documentation> Design documents, internal info, guides and help. [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies Code: Tests Measurement, self-control, statistics, balancing. [C++] Changes (can be) made in C++. Previously named `Code` [Markdown] Markdown issues and PRs Mods: Magiclysm Anything to do with the Magiclysm mod Mods: Aftershock Anything to do with the Aftershock mod labels Mar 4, 2024
@github-actions github-actions bot removed the astyled astyled PR, label is assigned by github actions label Mar 5, 2024
@github-actions github-actions bot added the astyled astyled PR, label is assigned by github actions label Mar 5, 2024
@github-actions github-actions bot removed the astyled astyled PR, label is assigned by github actions label Mar 6, 2024
@github-actions github-actions bot added the astyled astyled PR, label is assigned by github actions label Mar 6, 2024
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Mar 7, 2024
@github-actions github-actions bot removed the BasicBuildPassed This PR builds correctly, label assigned by github actions label Mar 7, 2024
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Mar 9, 2024
@Maleclypse Maleclypse merged commit 71ed5cd into CleverRaven:master Mar 9, 2024
23 of 26 checks passed
@GuardianDll GuardianDll deleted the enchantments_3 branch March 9, 2024 23:40
This was referenced Mar 10, 2024
Merged
Merged
Merged
This was referenced Mar 11, 2024
Merged
Merged
@KHeket KHeket mentioned this pull request Mar 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@mqrause mqrause mqrause left review comments

@John-Candlebury John-Candlebury Awaiting requested review from John-Candlebury

@KorGgenT KorGgenT Awaiting requested review from KorGgenT

@Maleclypse Maleclypse Awaiting requested review from Maleclypse

Assignees
No one assigned
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` Code: Tests Measurement, self-control, statistics, balancing. Crafting / Construction / Recipes Includes: Uncrafting / Disassembling <Documentation> Design documents, internal info, guides and help. Info / User Interface Game - player communication, menus, etc. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions [Markdown] Markdown issues and PRs Mechanics: Enchantments / Spells Enchantments and spells Mods: Aftershock Anything to do with the Aftershock mod Mods: Bombastic Perks Mods: Magiclysm Anything to do with the Magiclysm mod Mods: Mind Over Matter Mods: Xedra Evolved Anything to do with Xedra Evolved Mods Issues related to mods or modding Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GuardianDll @mqrause @Maleclypse