Maybe fix overmap test (disable geography scaling for tests) #72170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
[JSON]
RenechCDDA
force-pushed
the
maybe_fix_overmap_test_2
branch
from
92dac22 to
57d79da
Compare
|
Marked as ready to force it to run all tests If we still see overmap test fails on this PR, something is wrong and this should probably not be merged. |
github-actions
bot
added
the
BasicBuildPassed
|
Superseded by #72565 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
overmap_terrain_coveragetest fails, a LOT.Describe the solution
Add external option
OVERMAP_GEOGRAPHY_CHANGEwhich dictates whether these scalars apply at allTurn the option to off (false) in the TEST_DATA mod, which is (should?) always loaded when the tests are running
Describe alternatives you've considered
master...RenechCDDA:Cataclysm-DDA:maybe_fix_overmap_test
Previous attempt: Added new external option OVERMAPS_BEFORE_GEOGRAPHY_CHANGE, an option that serves as the cutoff where the geography changes kicks in: 10, as was previously expected.
After discussion with the dev team, the PR you're reading was the requested approach.
Testing
Relying mostly on github tests at this point. The test fails so frequently that success in one PR means a lot
Additional context