do not scope creep!

[GuardianDll]

Summary

None

Purpose of change

It happened

Describe the solution

Add some requirements for PRs in pull request template, visible by anyone who uses it

Describe alternatives you've considered

Additional bot checks to lock 500+ string PRs untill unblocked

[Fris0uman]

No one reads the template, it doesn't hurt to add a reminder but it should be more concise

[anoobindisguise]

Question. Does the bot count lines which are comments? Or empty lines? Both of those are tools which enhance legibility of code and I worry including them in the 500 line limit will encourage people to submit smooshed together, under commented code to try and fit the limit.

[PatrikLundell]

If the bot uses the incompetent git comparison you'll get a lot of "changed" lines when you remove a loop because all the lines within the loop are considered changed because they're white space shifted to have their indentation adjusted.

Also, you get "huge" changes if you move code, or factor common parts out into support functions, so any kind of attempt to organize things gets penalized.

[Maleclypse]

Thank you for getting to this before me. I can close a tab on my browser now.