[Magiclysm] Technomancer Mapping Spell

[rty275]

Summary

Mods "Technomancer map spell"

Purpose of change

At present, the only magiclysm class with a mapping spell was Earthshaper. This opens the ability up to all characters.

Describe the solution

Added a spell that lets technomancers map areas, modeled after the earthshaper spell.

Describe alternatives you've considered

There are a couple of ways I wanted to be able to do this. Making it use a pseudo-map like the earthshaper spell that only revealed MAN_MADE structures would have been great, but I didn't see a means of doing that and it would have been a nightmare to try and add every single viable location to a map. I also had thought it might be cool to place the map radius around the nearest radio tower rather than around the player, but I didn't see a way of doing that either. I'm sure it's not theoretically impossible to do those things, but it would take more skill at coding than I have, so this is what I got.

Testing

Spell casts properly, learns properly, and gives proficiencies properly. Spell scroll spawned properly in the item groups it was added to.

Additional context

While testing this I discovered that while the Novice Channeling proficiency correctly reduces cost and time to cast, Apprentice and Master seem to increase it again? I don't think that's an error with this PR given how I'm using the same math as every other spell, but it's worth looking into. EDIT: Made a PR to fix it, ended up being much easier than I thought.

[Maleclypse]

I don’t want to be a negative naysayer here but this is not reasonable. The only justification you’ve given is that people who choose technomancer over earthshaper don’t get map revealing spells. That’s a net good that they don’t. I’m fully against any class pairing ever having parity of utility. So the bar for this would already be high to me. But when you can’t make it thematically different so that there is at least some lore friendly reason for why they would get something similar I’m even more against it.

[Maleclypse]

I just saw in #mod-dev where Korg said no to this.

[rty275]

That was a no to the previous spell justification (satellite hookups), which I have since changed. I understand not wanting class parity though, but I do want to be clear that I didn't just make a PR based on something that was already said no to, my understanding was that Korg just said no to the theming, not the effect.

[Maleclypse]

i think a technomancer spell that gives you better-than-binocs omt reveal benefit would be distinct enough. just copying the earthshaper spell, no And I believe Guardian just jsonized that so you could make a recipe to improve binocs.

[rty275]

Oh really? I'll figure out how to do something like that then! Sorry about the confusion, I thought just changing the theming was enough but it does make sense that a plain map reveal is not really thematically appropriate. Still wish I could make it a radius around a radio tower or something instead, but that's definitely outside of my abilities.

[kevingranade]

As @Maleclypse says, "to give parity with other school" isn't a valid rationale for including something. The whole point of schools is so that magic is very different depending on which ones you have access to.

We were talking about a magic drone based spell in discord, I'm not totally clear whether just having it appear as an intangible part of the spell fits magiclysm or whether you'd want a concrete drone item, but I think it's a much better thematic fit.