-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ZenFS' sidebars to v2.1.1 #72130
Merged
Maleclypse
merged 5 commits into
CleverRaven:master
from
Zenefess:ZenFS'-sidebars-v2.1.1-update
Mar 4, 2024
Merged
Update ZenFS' sidebars to v2.1.1 #72130
Maleclypse
merged 5 commits into
CleverRaven:master
from
Zenefess:ZenFS'-sidebars-v2.1.1-update
Mar 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZenFS' sidebars now have the expedition timer integrated into their environment panels.
Readout integration for Magiclysm, Mind over Matter, Sky Island, and Xedra Evolved.
github-actions
bot
added
Info / User Interface
Game - player communication, menus, etc.
[JSON]
Changes (can be) made in JSON
Mods
Issues related to mods or modding
Bionics
CBM (Compact Bionic Modules)
Mods: Sky Island
Anything about the Sky Island mod
labels
Mar 3, 2024
ZenFS' sidebars now have the expedition timer integrated into their environment panels.
Readout integration for Magiclysm, Mind over Matter, Sky Island, and Xedra Evolved.
github-actions
bot
added
the
astyled
astyled PR, label is assigned by github actions
label
Mar 3, 2024
Readout integration for Magiclysm, Mind over Matter, Sky Island, and Xedra Evolved.
github-actions
bot
added
json-styled
JSON lint passed, label assigned by github actions
BasicBuildPassed
This PR builds correctly, label assigned by github actions
labels
Mar 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
astyled
astyled PR, label is assigned by github actions
BasicBuildPassed
This PR builds correctly, label assigned by github actions
Bionics
CBM (Compact Bionic Modules)
Info / User Interface
Game - player communication, menus, etc.
[JSON]
Changes (can be) made in JSON
json-styled
JSON lint passed, label assigned by github actions
Mods: Sky Island
Anything about the Sky Island mod
Mods
Issues related to mods or modding
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Interface "Integrates readouts from official mods into ZenFS' sidebars"
Purpose of change
I've been meaning to integrate readouts from a few official mods for a while; I finally had the time to get it all done. This update adds support for Mind over Matter's nether-attunement, Sky Island's expedition timer, and Xedra Evolved's blood hunger level. Also, overall readability of the panels was improved.
Describe the solution
Along with the existing mana readouts (for the mods Magiclysm and Xedra Evolved), hopefully this covers all critical information for the mods that come with the base game. Mod-specific information will only appear if your character qualifies; Mind over Matter's nether-attunement will only appear when your character has the effect, Sky Island's expedition timer will only appear if Sky Island is enabled, and Xedra Evolved's blood hunger status will only appear if your character is a vampire.
Describe alternatives you've considered
Extending panels with widgets is all well and good, but I have been intending to integrate mod-related readouts into the panels themselves; less space wasted by 1-line widgets means more map/log space.
Testing
Spent a couple of days stuffing around with different mod configurations to make sure each element was working as intended. I had to fix a few padding issues I missed, plus I finally added a maximum mana readout to the Numbar panels.
Additional context
Fresh character without mods; using graphless Numbar:
Fresh character with mods; using Numbar with body graphs and environment readout with overmap:
Fresh character with mods; using Numbar without body graphs and slim environment readout:
Fresh character with mods; using Thickbar with body graphs and environment readout with overmap:
Fresh character with mods; using Thickbar without body graphs and slim environment readout: