Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ZenFS' sidebars to v2.1.1 #72130

Merged

Conversation

Zenefess
Copy link
Contributor

@Zenefess Zenefess commented Mar 3, 2024

Summary

Interface "Integrates readouts from official mods into ZenFS' sidebars"

Purpose of change

I've been meaning to integrate readouts from a few official mods for a while; I finally had the time to get it all done. This update adds support for Mind over Matter's nether-attunement, Sky Island's expedition timer, and Xedra Evolved's blood hunger level. Also, overall readability of the panels was improved.

Describe the solution

Along with the existing mana readouts (for the mods Magiclysm and Xedra Evolved), hopefully this covers all critical information for the mods that come with the base game. Mod-specific information will only appear if your character qualifies; Mind over Matter's nether-attunement will only appear when your character has the effect, Sky Island's expedition timer will only appear if Sky Island is enabled, and Xedra Evolved's blood hunger status will only appear if your character is a vampire.

Describe alternatives you've considered

Extending panels with widgets is all well and good, but I have been intending to integrate mod-related readouts into the panels themselves; less space wasted by 1-line widgets means more map/log space.

Testing

Spent a couple of days stuffing around with different mod configurations to make sure each element was working as intended. I had to fix a few padding issues I missed, plus I finally added a maximum mana readout to the Numbar panels.

Additional context

Fresh character without mods; using graphless Numbar:
cataclysm-tiles_2024_03_03_11_27_57_374

Fresh character with mods; using Numbar with body graphs and environment readout with overmap:
cataclysm-tiles_2024_03_03_11_35_05_145
Fresh character with mods; using Numbar without body graphs and slim environment readout:
cataclysm-tiles_2024_03_03_11_35_44_821
Fresh character with mods; using Thickbar with body graphs and environment readout with overmap:
cataclysm-tiles_2024_03_03_11_36_52_925
Fresh character with mods; using Thickbar without body graphs and slim environment readout:
cataclysm-tiles_2024_03_03_11_37_06_193

Zenefess added 2 commits March 3, 2024 15:25
ZenFS' sidebars now have the expedition timer integrated into their environment panels.
Readout integration for Magiclysm, Mind over Matter, Sky Island, and Xedra Evolved.
@github-actions github-actions bot added Info / User Interface Game - player communication, menus, etc. [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Bionics CBM (Compact Bionic Modules) Mods: Sky Island Anything about the Sky Island mod labels Mar 3, 2024
Zenefess added 2 commits March 3, 2024 16:31
ZenFS' sidebars now have the expedition timer integrated into their environment panels.
Readout integration for Magiclysm, Mind over Matter, Sky Island, and Xedra Evolved.
@github-actions github-actions bot added the astyled astyled PR, label is assigned by github actions label Mar 3, 2024
@Zenefess Zenefess marked this pull request as ready for review March 3, 2024 05:55
data/json/ui/zenfs/limbs.json Outdated Show resolved Hide resolved
data/json/ui/zenfs/limbs_color.json Outdated Show resolved Hide resolved
data/json/ui/zenfs/movement.json Outdated Show resolved Hide resolved
data/json/ui/zenfs/pain.json Outdated Show resolved Hide resolved
data/json/ui/zenfs/stats.json Outdated Show resolved Hide resolved
data/json/ui/zenfs/temperature.json Outdated Show resolved Hide resolved
data/json/ui/zenfs/thirst.json Outdated Show resolved Hide resolved
data/json/ui/zenfs/wetness.json Outdated Show resolved Hide resolved
Readout integration for Magiclysm, Mind over Matter, Sky Island, and Xedra Evolved.
@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Mar 3, 2024
@Maleclypse Maleclypse merged commit aa09839 into CleverRaven:master Mar 4, 2024
18 of 24 checks passed
@Zenefess Zenefess deleted the ZenFS'-sidebars-v2.1.1-update branch March 5, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Bionics CBM (Compact Bionic Modules) Info / User Interface Game - player communication, menus, etc. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: Sky Island Anything about the Sky Island mod Mods Issues related to mods or modding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants