Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pch: remove pragma once #72121

Merged
merged 1 commit into from
Mar 3, 2024
Merged

Conversation

andrei8l
Copy link
Contributor

@andrei8l andrei8l commented Mar 2, 2024

Summary

None

Purpose of change

#pragma once doesn't make sense in the context of a PCH. gcc doesn't like it either and spams all build logs with this

Describe the solution

Remove pragma

Also delete the update-pch.sh script. It was never used, I should have never added it, and the PCH now includes several #ifdefs that the script can't preserve.

Describe alternatives you've considered

N/A

Testing

N/A

Additional context

N/A

@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Mar 2, 2024
@Maleclypse Maleclypse merged commit 8565ed9 into CleverRaven:master Mar 3, 2024
22 of 26 checks passed
@andrei8l andrei8l deleted the pch-no-pragma branch March 3, 2024 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants