Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust Muzzle Devices #72060

Merged
merged 8 commits into from
Mar 20, 2024
Merged

Conversation

tenmillimaster
Copy link
Member

Summary

Content "Adjusts various muzzle devices"

Purpose of change

Suppressors were the wrong length. You could craft suppressors too easily, forming threads somehow out of thin air, or magicking baffles into existence. Finally we had some unnecessary suppressor models, the rivtech one that was somehow better than regular ones, and the soda bottle suppressor which is frankly pretty useless. You could easily craft a rifle rated suppressor, which is a bit more difficult than just a pistol one.

Describe the solution

Migrated offending suppressors.
Improved the recipes for all craftable suppressors - Swapped the recipe for the suppressor to instead produce the pistol can.
Renamed the compact suppressor to the pistol suppressor as it's more clear.
Added alternate recipes for craftable suppressors using pre-existing muzzle attachments to take a small shortcut.
Adjusted pistol suppressor description.

Describe alternatives you've considered

24.2 welding rods seems like a LOT of welding rods to fully weld a suppressor, especially one doing a folded-sheetmetal construction. I tossed my conditions and calculated weld length into a weld calculator.
image
This is only about 6welding rods. I considered lowering the recipe to this.

Testing

Loaded game. Tried making stuff.

Additional context

None.

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Feb 29, 2024
@Hyperseeker
Copy link
Contributor

The official store listing for the Omega K series lists 45's length as 6.37″ = 161.8 mm ≈ 162 mm. Other sources (Silencer Warehouse, Guns n Gear) list it as 6.36″ = 161.54 mm ≈ 162 mm. Out of the top 10 results on Google, the only one to list it at 6.4″ = 162.56 mm ≈ 163 mm is Silencer Shop.

Salvo 12 is stated to have the maximum length of 12.5″ = 317.5 mm ≈ 318 mm (or 12.52″ = 318.01 mm ≈ 318 mm, if you believe Silencer Shop). It doesn't appear to be able to change length to slightly under 12″: the steps (however inaccurate) are stated to start with 10″.

Hybrid 46 DTM comes down to 7.8″ = 198.12 mm ≈ 198 mm OAL.

@tenmillimaster
Copy link
Member Author

tenmillimaster commented Feb 29, 2024

The official store listing for the Omega K series lists 45's length as 6.37″ = 161.8 mm ≈ 162 mm. Other sources (Silencer Warehouse, Guns n Gear) list it as 6.36″ = 161.54 mm ≈ 162 mm. Out of the top 10 results on Google, the only one to list it at 6.4″ = 162.56 mm ≈ 163 mm is Silencer Shop.

Salvo 12 is stated to have the maximum length of 12.5″ = 317.5 mm ≈ 318 mm (or 12.52″ = 318.01 mm ≈ 318 mm, if you believe Silencer Shop). It doesn't appear to be able to change length to slightly under 12″: the steps (however inaccurate) are stated to start with 10″.

Hybrid 46 DTM comes down to 7.8″ = 198.12 mm ≈ 198 mm OAL.

I'm going to update the values again based on the stats in their manuals, here: https://silencerco.com/wp-content/uploads/2020/09/Salvo_Manual-web.pdf https://silencerco.com/wp-content/uploads/2020/05/Hybrid_Manual.pdf https://silencerco.com/wp-content/uploads/2020/05/OmegaK_Manual.pdf

EDIT: OK the 46 DTM is actually all over the place for numbers, the manual isn't very close to listings, nor is it specific to the DTM offering.

@github-actions github-actions bot removed the json-styled JSON lint passed, label assigned by github actions label Feb 29, 2024
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot added the json-styled JSON lint passed, label assigned by github actions label Feb 29, 2024
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Mar 5, 2024
@Cenness
Copy link

Cenness commented Mar 8, 2024

Would be nice if someone also adjusted holsters, so we could finally skip crafting big variants to be able to use them with suppressed handguns.

@tenmillimaster
Copy link
Member Author

tenmillimaster commented Mar 8, 2024

Would be nice if someone also adjusted holsters, so we could finally skip crafting big variants to be able to use them with suppressed handguns.

You would have to do that regardless after any adjustment to existing holsters. You can't holster a supressed pistol in a standard holster.

@kevingranade kevingranade merged commit 34f5ca2 into CleverRaven:master Mar 20, 2024
22 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants