NPCs use their indoor voices when not in danger

[RenechCDDA]

Summary

Balance "NPCs don't scream at loudness 16 when just saying normal stuff, unless they're in danger"

Purpose of change

Mentioned in #71865 (does not close issue)

NPCs yelling like maniacs in the middle of the night because they wanted to step past you. Then yelling like maniacs to apologize to all the people they just woke up. Brilliant.

Describe the solution

Replaced the number 16 with 6 if not in danger math!

Calculate a good volume to use instead of magic numbers, based on whether the player will be able to hear (speak louder if PC is far away)/NPC wants the player to hear. Respects if friends are sleeping (intentionally whispers to avoid waking them up).

Describe alternatives you've considered

Why don't we make a slider for the player to micromanage how loud they want their NPCs to yell? (this is not a serious question)

Testing

Confirmed it compiles and launches only

Additional context

Technically speaking if get_shout_volume() is below 16, they were actually louder when speaking normally during danger 🤔

[Nebnis]

Why don't we make a slider for the player to micromanage how loud they want their NPCs to yell? (this is not a serious question)

I mean, i would love this. Something like:

"Try to be quiet as much as possible but scream really loud if you in danger and alone(not following player)."

[RenechCDDA]

Why don't we make a slider for the player to micromanage how loud they want their NPCs to yell? (this is not a serious question)

I mean, i would love this. Something like:

"Try to be quiet as much as possible but scream really loud if you in danger and alone(not following player)."

Exactly why it is going to be done programmatically and not by having the player repeatedly change settings for things the NPCs should be smart enough to handle.

[XygenSS]

Can this be done with the player character as well?

[RenechCDDA]

Can this be done with the player character as well?

The player does not make verbal sound except when using the You yell... command. (And working out, and casting verbal spells, and occasionally when in pain. But none of those are terribly relevant.)

As far as I can tell, yelling orders doesn't make any noise either.

So there is nothing to be done here, except maybe add noise from talking.

[XygenSS]

As far as I can tell, yelling orders doesn't make any noise either.
So there is nothing to be done here, except maybe add noise from talking.

Is that really the case? Telling followers to guard or follow via the C menu seems to produce sound equal to your usual yelling volume.

talking to them does seem to be completely silent on your part though, noise definitely should be added.

[Theawesomeboophis]

The player talking should definitely make sound.

[Theawesomeboophis]

Why don't we make a slider for the player to micromanage how loud they want their NPCs to yell? (this is not a serious question)

I mean, i would love this. Something like:

"Try to be quiet as much as possible but scream really loud if you in danger and alone(not following player)."

We should probably have a be quiet command so they're not screaming during night raids and stuff and alerting everything nearby. Because stealthing with npcs is kinda hard when they're yelling at you that they see a zombie 4 miles down the road.

[Montimorency]

Can this be done with the player character as well?

The player does not make verbal sound except when using the You yell... command. (And working out, and casting verbal spells, and occasionally when in pain. But none of those are terribly relevant.)

As far as I can tell, yelling orders doesn't make any noise either.

So there is nothing to be done here, except maybe add noise from talking.

Are we sure about that?

"Everyone take it easy", Dumbledore said calmly.

No, but for real, some chat menu commands are single-digit volume, while others are - maximal? I can't find the consistency.

[RenechCDDA]

You're right, it looks like the player actually shouts for those commands. I didn't find it because it's in npctalk.cpp, the last place I expected to find the player talking.

Any problems you find there should be made into a new issue though