Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a reward for finishing Dino Dave's quest chain #71983

Merged
merged 20 commits into from
Mar 22, 2024

Conversation

carlarctg
Copy link
Contributor

@carlarctg carlarctg commented Feb 26, 2024

Summary

Content "Adds reward for Dino Dave's quests"

Purpose of change

Add some silly and enjoyable rewards for letting Dave build his cardboard fort, without actually straining credulity.

Describe the solution

This PR adds a recipe book as reward for completing Dave's cardboard quests. It lets you make a whole bunch of completely and utterly ineffective cardboard armor and weapons, alongside a crown and a badge you're given for free on completion.

The armor barely protects and dissolves in water (cardboard and rivers dont mix), the weapons lose a bar of health every hit. They're not actually useful, it's just for fun. Maybe for arming your NPC companions in your own large cardboard fort?

You can actually learn from the skillbook, by the way. Fabrication 4-6. The implication is that Dave had some background in something relevant to knowing about material integrity and went way overboard on the details, letting you learn something from the way he describes the items and ingredients. It requires intelligence 13 to untangle easily though.

Describe alternatives you've considered

Adding some form of actual, functional cardboard armor by mixing the material with water to create a solid mass. Decided not to bother as that's just overdoing the joke.

Adding many more cardboard recipes. Ditto.

Just giving the player the cardboard items directly. No, what if they want to make more after they inevitably fall apart? Or 'arm' their companions?

Adding an actual reward. No, what would Dave have to give you? This is silly but fits perfectly with his character and abilities.

Making the skillbook skill 0. I think it's a fun subtle addition to imply that Dave has some knowledge of how materials work and that transferred over to his cardboard mania enough for him to be skilled at constructing with cardboard. It makes sense, adds a small amount of depth to his character, and explains his expertise with it.

Testing

Spawned myself in, did the quests, got the book after waiting a day. Crafted and spawned the items, properly ensured they did not work properly, as planned.

Additional context

Maybe people will do Dave's quests more now that they have a tangible (until it hits water) reward!

Actual content:

Dave's recipe book, fabrication 4-6, Intelligence 13 complexity

Armor, useless and fragile
Cuirass, slightly less useless
Great helm, protects from mind-control rays!
Crown, can be loosened to fit on the outer layer. Dave also wears one now.
Badge, made by Dave himself and given upon quest completion.
Sword and spear, they break every hit.

image
image
image
image
image

These recipes are only found in Dave's book. They can't be crafted until the quest chain is finished and the book read.

@github-actions github-actions bot added NPC / Factions NPCs, AI, Speech, Factions, Ownership [JSON] Changes (can be) made in JSON Items: Armor / Clothing Armor and clothing labels Feb 26, 2024
@worm-girl
Copy link
Contributor

image

@github-actions github-actions bot added the astyled astyled PR, label is assigned by github actions label Feb 26, 2024
@PatrikLundell
Copy link
Contributor

I wouldn't add the sword and spear, as Dave surely would know they're completely worthless (unless he believes in cardboard susceptible shades). The armor makes more sense, as it might "hide" you from "them", and thus actually have a "function".

@github-actions github-actions bot added the json-styled JSON lint passed, label assigned by github actions label Mar 2, 2024
@Inglonias
Copy link
Contributor

this is really cute. I like this.

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Mar 8, 2024
data/json/items/book/fabrication.json Outdated Show resolved Hide resolved
data/json/items/book/fabrication.json Outdated Show resolved Hide resolved
Copy link
Member

@I-am-Erk I-am-Erk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So for certain of the characters I created, I have to work hard to squelch the urge to not want anyone to change them. It's of course totally at odds with the fact that I made them specifically hoping someone else would take them and run with them, but any time I open a PR like this I get super nervous about how I might feel.

On that note, you've knocked this out of the park. I totally love it. Thank you. I would only ask that you remove the cardboard weaponry: Dave views cardboard as a force for protection, not harm.

To make Erk's request to you easy if you'd like
Copy link
Contributor

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • *bows deeply. "Thank you. Our expertise with the most sacred of materials comes from a past long gone." He gazes off into the distance, lost in thought. You wait, but he doesn't talk again.
  • A cardboard helmet shaped to look like a medieval great helm. Very unencumbering in comparison to actual helmets, with rather obvious drawbacks in exchange. The interior is lined with aluminum, apparently to 'divert the zombie beta rays'. It sure doesn't help with comfort.
  • A set of cardboard armor that's been duct taped and superglued into place, with paper padding the interior in an unsuccessful attempt to increase comfort. Despite the triple-layering, tensile and shear strength diagrams, and careful design considerations, there's just no way this is going to hold up to a single attack.
  • While this isn't quite the 'heavy ballistic vest' the blueprints pretend it is, the layering makes it almost passable as a form of extremely rudimentary armor. It's still nowhere near as good as basically any other choice, while still being hard to move around in.

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

@Maleclypse Maleclypse requested a review from I-am-Erk March 22, 2024 00:17
@Maleclypse Maleclypse merged commit 2dbf12c into CleverRaven:master Mar 22, 2024
22 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Items: Armor / Clothing Armor and clothing [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions NPC / Factions NPCs, AI, Speech, Factions, Ownership
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants