Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace stdafx.h with pch/main-pch.hpp #71829

Merged
merged 9 commits into from
Feb 23, 2024
Merged

Conversation

alef
Copy link
Contributor

@alef alef commented Feb 18, 2024

Summary

Build "Use one precompiled header"

Purpose of change

Since stdafx.h and pch/main-pch.hpp are quite similar, let us use only one.

Describe the solution

  • Merged stdafx.h content into pch/main-pch.hpp
  • Changed the msvc-full-features solution files to point to the new include
  • stdafx.cpp includes the new pch

Describe alternatives you've considered

Testing

Compile and link the following:

  • Visual Studio msvc-full-features Solution
  • Linux Makefile with TILES=1 SOUND=1 CCACHE=1 PCH=1
  • CMake MSYS2/MINGW/UCRT64
  • CMake MSVC

Additional context

Keep this in draft for some time to double check local builds performance.

@github-actions github-actions bot added Code: Build Issues regarding different builds and build environments Code: Tests Measurement, self-control, statistics, balancing. [C++] Changes (can be) made in C++. Previously named `Code` astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Feb 18, 2024
pch/main-pch.hpp Outdated Show resolved Hide resolved
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Feb 19, 2024
@alef alef marked this pull request as ready for review February 20, 2024 21:16
@akrieger
Copy link
Member

Are all the project file changes needed, or are those some intermediate steps? Everything should be expressable in Cataclysm-common.props.

@Maleclypse Maleclypse merged commit 59c9d12 into CleverRaven:master Feb 23, 2024
26 checks passed
@alef alef deleted the onepch branch February 24, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` Code: Build Issues regarding different builds and build environments Code: Tests Measurement, self-control, statistics, balancing. json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants