Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide more info for translators in EoC messages #71352

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

BrettDong
Copy link
Member

Summary

None

Purpose of change

All EoC texts show as "Message about the player in an effect" in developer notes, which is not useful enough for translators:

transifex

Describe the solution

Provide more context in developer notes.

Describe alternatives you've considered

Testing

In the example message shown above, the new developer notes reads

#. ~ Player message in false effect in EoC "EOC_VITAKIN_RESTORE_LIMB_RIGHT_LEG_RESULT"
#. ~ Player message in false effect in EoC "EOC_VITAKIN_RESTORE_LIMB_LEFT_LEG_RESULT"
#. ~ Player message in false effect in EoC "EOC_VITAKIN_RESTORE_LIMB_RIGHT_ARM_RESULT"
#. ~ Player message in false effect in EoC "EOC_VITAKIN_RESTORE_LIMB_LEFT_ARM_RESULT"
#: data/mods/Limb_WIP/mod_integration/vitakinesis_eoc.json
msgid "Your healing powers were not great enough, you'll have to try again."
msgstr ""

Additional context

@github-actions github-actions bot added Translation I18n Crafting / Construction / Recipes Includes: Uncrafting / Disassembling [Python] Code made in Python EOC: Effects On Condition Anything concerning Effects On Condition astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Jan 30, 2024
@BrettDong BrettDong added the 0.H Backport PR to backport to the 0.H stable release canddiate label Jan 30, 2024
Copy link
Contributor

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • You feel a multitude of foes coming for you, bleary-eyed and full of bloodlust. Steel yourself, for the horde is coming.

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jan 30, 2024
@ZhilkinSerg ZhilkinSerg merged commit 54d5a60 into CleverRaven:master Jan 30, 2024
18 of 22 checks passed
@BrettDong BrettDong deleted the translate-eoc-context branch January 31, 2024 03:45
Procyonae pushed a commit to Procyonae/Cataclysm-DDA that referenced this pull request May 16, 2024
@Procyonae Procyonae mentioned this pull request May 16, 2024
kevingranade pushed a commit that referenced this pull request May 17, 2024
@Procyonae Procyonae added 0.H Backported and removed 0.H Backport PR to backport to the 0.H stable release canddiate labels May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.H Backported astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Crafting / Construction / Recipes Includes: Uncrafting / Disassembling EOC: Effects On Condition Anything concerning Effects On Condition json-styled JSON lint passed, label assigned by github actions [Python] Code made in Python Translation I18n
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants