Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ Xedra Evolved ] Väinämöinen's Kantele #71128

Merged
merged 9 commits into from
Apr 10, 2024

Conversation

Maleclypse
Copy link
Member

@Maleclypse Maleclypse commented Jan 21, 2024

Summary

None

Purpose of change

Adds magical Kantele to Xedra Evolved. Inspired by #71118

Describe the solution

Add magic kantele that is player craftable and add artifact grade kantele. Add spell. To do, add recipe for crafted kantele, and add way to gain Artifact Kantele. Probably a quest from Boann.

Describe alternatives you've considered

None

Testing

tbd

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Mechanics: Enchantments / Spells Enchantments and spells Mods: Xedra Evolved Anything to do with Xedra Evolved labels Jan 21, 2024
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-requesting reviews from non-collaborators: @GuardianDll

@github-actions github-actions bot added the astyled astyled PR, label is assigned by github actions label Jan 21, 2024
Update item_spells.json

Update data/mods/Xedra_Evolved/items/artifact_grade_items.json
@Maleclypse Maleclypse force-pushed the Väinämöinen's-Kantele branch from 6e5d72f to b967e4a Compare January 21, 2024 04:29
@github-actions github-actions bot added the json-styled JSON lint passed, label assigned by github actions label Jan 21, 2024
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jan 21, 2024
@github-actions github-actions bot removed the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jan 21, 2024
@github-actions github-actions bot added BasicBuildPassed This PR builds correctly, label assigned by github actions and removed BasicBuildPassed This PR builds correctly, label assigned by github actions labels Jan 21, 2024
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

@github-actions github-actions bot added the stale Closed for lack of activity, but still valid. label Feb 21, 2024
@Maleclypse Maleclypse removed the stale Closed for lack of activity, but still valid. label Mar 11, 2024
Co-authored-by: Jianxiang Wang (王健翔) <[email protected]>
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Mar 11, 2024
…perk_data/Alchemy1.json

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Copy link
Contributor

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • An original kantele made by Väinämöinen himself. Fashioned from a great pike's jawbone, the material is unlike anything you saw before the end of the world. Every note from this instrument thrums with power.
  • Väinämöinen's Kantele
  • Väinämöinen's Kantele Song
  • Väinämöinen's Kantele, imitation
  • Väinämöinen's Kanteles
  • Väinämöinen's Kanteles, imitation

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

Hints for adding a new word to the dictionary
  • If the word is normally in all lowercase, such as the noun word or the verb does, add it in its lower-case form; if the word is a proper noun, such as the surname George, add it in its initial-caps form; if the word is an acronym or has special letter case, such as the acronym CDDA or the unit mW, add it by preserving the case of all the letters. A word in the dictionary will also match its initial-caps form (if the word is in all lowercase) and all-uppercase form, so a word should be added to the dictionary in its normal letter case even if used in a different letter case in a sentence.
  • For a word to be added to the dictionary, it should either be a real, properly-spelled modern American English word, a foreign loan word (including romanized foreign names), or a foreign or made-up word that is used consistently and commonly enough in the game. Intentional misspelling (including eye dialect) of a word should not be added unless it has become a common terminology in the game, because while someone may have a legitimate use for it, another person may spell it that way accidentally.

@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions and removed json-styled JSON lint passed, label assigned by github actions labels Apr 10, 2024
@dseguin dseguin merged commit 1ab0912 into CleverRaven:master Apr 10, 2024
24 checks passed
@Maleclypse Maleclypse deleted the Väinämöinen's-Kantele branch April 18, 2024 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mechanics: Enchantments / Spells Enchantments and spells Mods: Xedra Evolved Anything to do with Xedra Evolved Mods Issues related to mods or modding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants