Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #67611 #70743

Merged
merged 1 commit into from
Jan 9, 2024
Merged

Fix #67611 #70743

merged 1 commit into from
Jan 9, 2024

Conversation

alef
Copy link
Contributor

@alef alef commented Jan 7, 2024 •
edited
Loading

Map only indexes that are visible

Summary

Bugfixes "Fix #67611"

Purpose of change

Fix "Using the mouse on menus with nested elements malfunctions"

Describe the solution

Running under MSVC debugger until I found opt_line_map was mapping screen indices (i) instead of the visible ones mapped by visible_items[].

Describe alternatives you've considered

N/A

Testing

  • ✅ Tested on Windows+SDL
  • ❌ Not tested on Linux+SDL or non-SDL
  • ✅ Not tested on scrollling

Additional context

To be considered for #70661 since in O.H Release Triage

@alef
Fix CleverRaven#67611
9946afc 
Map only indexes that are visible
@github-actions github-actions bot added [C++] Changes (can be) made in C++. Previously named `Code` <Bugfix> This is a fix for a bug (or closes open issue) json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Jan 7, 2024
@alef alef marked this pull request as ready for review January 8, 2024 21:10
@Maleclypse Maleclypse merged commit 061595f into CleverRaven:master Jan 9, 2024
41 checks passed
@alef alef deleted the 67611-visible_items branch January 9, 2024 05:24
Procyonae pushed a commit to Procyonae/Cataclysm-DDA that referenced this pull request May 19, 2024
@alef @Procyonae
Merge pull request CleverRaven#70743 from alef/67611-visible_items
754bd27 
Fix CleverRaven#67611
@Procyonae Procyonae mentioned this pull request May 19, 2024
Merged
dseguin added a commit that referenced this pull request May 19, 2024
@dseguin
Merge pull request #73927 from Procyonae/Backport70743
92cb438 
Backport #70743
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
0.H Backported astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Using the mouse on menus with nested elements malfunctions
3 participants
@alef @Procyonae @Maleclypse