Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discard invalid PO files in pull translations GHA workflow #69255

Merged
merged 1 commit into from
Nov 11, 2023

Conversation

BrettDong
Copy link
Member

Summary

None

Purpose of change

Sometimes PO files pulled from Transifex are not accepted by GNU gettext, cause Basic Build CI test to fail and block merging of the translation update pull requests. This has happened in the last two weeks in a row.

Describe the solution

Added a simple bash script after pulling translations from Transifex, that reverts any PO file that cannot be processed by GNU gettext.

Describe alternatives you've considered

Testing

Additional context

@github-actions github-actions bot added Translation I18n Code: Tooling Tooling that is not part of the main game but is part of the repo. json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Nov 11, 2023
@Maleclypse Maleclypse merged commit b553335 into CleverRaven:master Nov 11, 2023
21 checks passed
@BrettDong BrettDong deleted the discard_invalid_po branch November 12, 2023 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Code: Tooling Tooling that is not part of the main game but is part of the repo. json-styled JSON lint passed, label assigned by github actions Translation I18n
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants