Improve item volume loading #69238
Merged
Improve item volume loading #69238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't roll our own quantity parsing code in multiple places, just use the already written code that works better.
github-actions
bot
added
[C++]
github-actions
bot
added
the
BasicBuildPassed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: None
Purpose of change
Items can't specify volume like
"40 L 500 ml".Describe the solution
Don't roll special quantity parsing code in multiple places, just use the already written code that works better.
Testing
All item volumes load as before. Item volumes specified with two units (as above) work.
Additional context
When working on #68988, I noticed that quantities supported loading in this syntax, and I had been annoyed by the "one unit only" approach items use in the past.
Weight, length, etc already use this style.