Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CR] AFS Exosuit Updates III #69186

Merged
merged 23 commits into from
Mar 24, 2024
Merged

[CR] AFS Exosuit Updates III #69186

merged 23 commits into from
Mar 24, 2024

Conversation

Drew4484
Copy link
Contributor

@Drew4484 Drew4484 commented Nov 8, 2023 •
edited
Loading

Summary

Content "Collection of fixes and updates to Exosuits"

Purpose of change

Climate control removal from exosuits leaves pilots too cold even with underlayer.
Power sources lacked USE_UPS and could not have their own power storage charged from another source.

Describe the solution

  • Adjust underlayer climate control.
  • Add USE_UPS to all battery modules.
  • Add light exosuit frame: more compact, lighter, lower power consumption. Lacks modular armor and has reduced number of module slots.
  • Add more spawns for frames and equipment.
  • Remove Underlayer slot from frame pockets.

Describe alternatives you've considered

Testing

  • UPS fix
  • Light frame functionality.
  • Itemgroups for light frames.
  • Spawns for light frame.
  • Review power consumption (consuming too little ATM)

Additional context

This resolves #69143.

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Mods: Aftershock Anything to do with the Aftershock mod Items: Armor / Clothing Armor and clothing astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Nov 8, 2023
@Drew4484 Drew4484 force-pushed the AFS-Exosuit-Updates-III branch from 855d938 to 7b4b0e9 Compare November 8, 2023 21:34
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Nov 9, 2023
@Drew4484
Copy link
Contributor Author

Drew4484 commented Nov 9, 2023

Will resolve #69143

@github-actions github-actions bot added Map / Mapgen Overmap, Mapgen, Map extras, Map display Spawn Creatures, items, vehicles, locations appearing on map and removed BasicBuildPassed This PR builds correctly, label assigned by github actions labels Nov 15, 2023
@github-actions github-actions bot added Melee Melee weapons, tactics, techniques, reach attack [C++] Changes (can be) made in C++. Previously named `Code` Items: Ammo / Guns Ammunition for all kinds of weapons and these weapons themselves json-styled JSON lint passed, label assigned by github actions and removed json-styled JSON lint passed, label assigned by github actions labels Nov 22, 2023
@Drew4484 Drew4484 force-pushed the AFS-Exosuit-Updates-III branch from 878b444 to 0871d88 Compare November 26, 2023 10:32
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Nov 27, 2023
@Drew4484 Drew4484 force-pushed the AFS-Exosuit-Updates-III branch from 4fd4445 to 340fc35 Compare December 28, 2023 20:42
@github-actions GitHub Actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

@github-actions github-actions bot added the stale Closed for lack of activity, but still valid. label Jan 27, 2024
@github-actions github-actions bot closed this Feb 27, 2024
@Drew4484 Drew4484 reopened this Mar 14, 2024
@github-actions github-actions bot added stale Closed for lack of activity, but still valid. and removed stale Closed for lack of activity, but still valid. labels Mar 14, 2024
@github-actions github-actions bot added the json-styled JSON lint passed, label assigned by github actions label Mar 15, 2024
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Mar 15, 2024
@github-actions github-actions bot removed json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Mar 17, 2024
@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Mar 18, 2024
@Drew4484 Drew4484 marked this pull request as ready for review March 19, 2024 00:58
@Drew4484 Drew4484 requested review from John-Candlebury and removed request for John-Candlebury March 19, 2024 00:58
@github-actions github-actions bot removed the BasicBuildPassed This PR builds correctly, label assigned by github actions label Mar 19, 2024
@github-actions github-actions bot removed the json-styled JSON lint passed, label assigned by github actions label Mar 21, 2024
@github-actions GitHub Actions
Copy link
Contributor

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • A form-fitting suit meant to be worn by an exosuit pilot. Although not a requirement for the operation of an exosuit, it features haptic feedback systems that offer improved performance and comfort while doing so. The suit is not designed for use outside of armor. This model offers tough kevlar to protect from spalling.

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

@github-actions github-actions bot added the json-styled JSON lint passed, label assigned by github actions label Mar 21, 2024
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Mar 22, 2024
@akrieger
Copy link
Member

Additional context: WIP

Is it still WIP?

@Drew4484
Copy link
Contributor Author

Additional context: WIP

Is it still WIP?

WIP no more, good to go now.

@akrieger akrieger merged commit 91f42e3 into CleverRaven:master Mar 24, 2024
25 checks passed
Drew4484 added a commit to Drew4484/Cataclysm-DDA that referenced this pull request Apr 3, 2024
@Drew4484
Update exosuit_frame.json
cd4c19e 
A local commit did not successfully push before CleverRaven#69186 was merged.
@Drew4484 Drew4484 mentioned this pull request Apr 3, 2024
Merged
Drew4484 added a commit to Drew4484/Cataclysm-DDA that referenced this pull request Apr 3, 2024
@Drew4484
Update exosuit_frame.json
65eb9c8 
A local commit did not successfully push before CleverRaven#69186 was merged.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@John-Candlebury John-Candlebury John-Candlebury left review comments

@Maleclypse Maleclypse Awaiting requested review from Maleclypse

Assignees
No one assigned
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` Items: Ammo / Guns Ammunition for all kinds of weapons and these weapons themselves Items: Armor / Clothing Armor and clothing [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Map / Mapgen Overmap, Mapgen, Map extras, Map display Melee Melee weapons, tactics, techniques, reach attack Mods: Aftershock Anything to do with the Aftershock mod Mods Issues related to mods or modding Spawn Creatures, items, vehicles, locations appearing on map
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Aftershock] Exosuit power supplies do not function in PSU pocket
3 participants
@Drew4484 @akrieger @John-Candlebury