Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Xedra Evolved] Rubik dialogue about Jotunn quads #68311

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

Maleclypse
Copy link
Member

Summary

None

Purpose of change

Someone mentioned that Rubik should talk about the heavy combat units that exist in XE. So it will. Discovered that any way I wanted to make this relevant it would require dialogue conditionals to check for achievements, so I'm attempting to make that work.

Describe the solution

Adds code for checking achievements in dialogue and then adds the dialogue.

Describe alternatives you've considered

None

Testing

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding [C++] Changes (can be) made in C++. Previously named `Code` Game: Achievements / Conducts / Scores Player goals and how they are tracked. EOC: Effects On Condition Anything concerning Effects On Condition Mods: Xedra Evolved Anything to do with Xedra Evolved labels Sep 25, 2023
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-requesting reviews from non-collaborators: @GuardianDll

src/condition.cpp Outdated Show resolved Hide resolved
src/condition.cpp Outdated Show resolved Hide resolved
src/condition.cpp Outdated Show resolved Hide resolved
src/condition.h Outdated Show resolved Hide resolved
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Sep 25, 2023
src/avatar.cpp Outdated Show resolved Hide resolved
src/avatar.cpp Outdated Show resolved Hide resolved
src/avatar.cpp Outdated Show resolved Hide resolved
src/avatar.cpp Outdated Show resolved Hide resolved
src/avatar.cpp Outdated Show resolved Hide resolved
src/avatar.cpp Outdated Show resolved Hide resolved
src/avatar.cpp Outdated Show resolved Hide resolved
src/avatar.cpp Outdated Show resolved Hide resolved
src/avatar.cpp Outdated Show resolved Hide resolved
src/avatar.cpp Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the astyled astyled PR, label is assigned by github actions label Sep 25, 2023
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
src/avatar.cpp Outdated Show resolved Hide resolved
@github-actions github-actions bot added the astyled astyled PR, label is assigned by github actions label Sep 25, 2023
@github-actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

@github-actions github-actions bot added the stale Closed for lack of activity, but still valid. label Oct 25, 2023
@github-actions github-actions bot closed this Nov 24, 2023
@Maleclypse Maleclypse reopened this Sep 9, 2024
@Maleclypse Maleclypse removed the stale Closed for lack of activity, but still valid. label Sep 9, 2024
@github-actions github-actions bot added the stale Closed for lack of activity, but still valid. label Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` EOC: Effects On Condition Anything concerning Effects On Condition Game: Achievements / Conducts / Scores Player goals and how they are tracked. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: Xedra Evolved Anything to do with Xedra Evolved Mods Issues related to mods or modding stale Closed for lack of activity, but still valid.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants