[WIP] Dermatik jsonification #66358
Closed
[WIP] Dermatik jsonification #66358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
[C++]
RenechCDDA
reviewed
Jul 1, 2023
RenechCDDA
reviewed
Jul 1, 2023
data/json/effect_on_condition.json
Outdated
| "effect": [ | ||
| { "u_message": "Your flesh crawls… A larva tears through your flesh and begins to emerge!", "type": "bad" }, | ||
| { "u_spawn_monster": "mon_dermatik_larva", "real_count": 1, "min_radius": 1, "max_radius": 4 }, | ||
| { "u_lose_effect": "dermatik" } |
There was a problem hiding this comment.
Add a new effect called dermatik_damage that ticks once and applies the damage right after this eoc fires
Karol1223
force-pushed
the
dermalads
branch
2 times, most recently
from
6c820f4 to
2fb31ab
Compare
github-actions
bot
added
json-styled
Uwuewsky
reviewed
May 1, 2024
github-actions
bot
removed
the
json-styled
Co-Authored-By: Anton Simakov <[email protected]>
EOCs all done by Guardian Co-Authored-By: Anton Simakov <[email protected]>
Co-authored-by: Uwuewsky <[email protected]>
|
The very important events |
Yeah most things do. This is broken as fuck. I am not getting to this anytime soon, I'm just rebasing it so the conflicts don't stack up. It's one of those PRs I frankly don't want to deal with anymore because it's just a bunch of annoyances. EDIT: Actually fuck it. I have no reason to finish this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Dermatiks have had insane amounts of VERY evil hardcoding going on and with the recent grab changes and the power of EOCs it should be possible to jsonify them. Will it work? I damn well hope so!
Describe the solution
So far complete jsonification of the
DERMATIKspecial attack. It is largely unchanged - it may have a different effect duration and can no longer be swatted away with cattle tail but for the most part the rest should be similar/the same (I hope)I plan to jsonify
effect_dermatikif I don't lose my sanity but this has proven to be a lot more work than I initially thought it'd be so we'll see what happens...Describe alternatives you've considered
Testing
NOT TESTED YET! WILL DO ONCE I'M SATISFIED WITH THE STATE OF THIS!
Additional context