Reduce repetitive output color changes

[sparr]

Summary

None

Purpose of change

Functions like mvwputch change the color then change it back, so calling them repeatedly, especially in a loop, results in a massive amount of duplication of effort.

Describe the solution

Use the non-color-changing versions of the function and specify the color explicitly before and after the loops and other calls.
I've also replaced many such loops with mvwvline and mvwhline, and added the new mvwrectf for 2d fill loops.

Describe alternatives you've considered

Testing

See comments for testing at various versions of the PR.

Additional context

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

[Night-Pryanik]

@sparr care to resolve conflicts?

[sparr]

Sure, although I might abandon a few of them if the code has changed too much in the last year.

[sparr]

Working on the conflicts now. Glad to see some of the imgui stuff replacing old manually assembled UIs. Compiles are so much slower on my backup laptop :(

[NetSysFire]

You can make the github CI spit out builds for your PR, too. Simply change the branch in .github/workflows/release.yml in your fork and check the releases page after a while.

[sparr]

@Night-Pryanik conflicts are fixed. I tested most of it. I wasn't able to quickly come up with a test environment for the following:

basecamp::worker_assignment_ui
basecamp::job_assignment_ui
talk_function::draw_camp_tabs
game::reset_item_list_state
iexamine::vending
exosuit_interact
robot_finds_kitten::show()
snake_game::start_game()

[Night-Pryanik]

Ok, thanks a lot! I'll see if I can find a time to test it soon.