Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bird Audit - Passerines #73087

Merged
merged 8 commits into from
Apr 21, 2024
Merged

Bird Audit - Passerines #73087

merged 8 commits into from
Apr 21, 2024

Conversation

Karol1223
Copy link
Contributor

@Karol1223 Karol1223 commented Apr 17, 2024

Summary

None

Purpose of change

Remake our old passerine birds, add two new ones

Describe the solution

  • Made all the old passerines (robin, crow, raven, blue jay, sparrow, cardinal) copy from the new flying bird abstract, corrected their sizes in accordance to wikipedia (and not only sizes, some growth timers and reproduction timers as well)
  • renamed crow to American crow, robin to American robin, sparrow to house sparrow
  • Audited the values for their eggs to be proportionally calculated from sparrow eggs (which internet says is 3g)
  • Audited the amount of eggs of theirs it takes for recipes (included a fix for pigeon eggs here as well)
  • Made pigeon chicks grow slightly faster
  • Added two new birds - black-capped chickadee and cedar waxwing (I told ya'll I'll add the waxwings)
  • Audited nutritional value for eggs since they were larger than normal large eggs for some reason which caused weirdness

Tamable wildlife changes:

  • Removed the unnecessary pigeon definition since pigeons were already tamable in vanilla
  • Removed the unnecessary name strings for birds - those get copied anyway, they were just wasting space and making my life harder during renaming
  • Added the two new passerines to be tamable

Describe alternatives you've considered

Testing

Additional context

@Termineitor244 I thought Tamable Wildlife was supposed to make young animals tamable - is it intentional that bird chicks aren't tamable but adult birds are?

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Spawn Creatures, items, vehicles, locations appearing on map Mods: Tamable Wildlife labels Apr 17, 2024
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-requesting reviews from non-collaborators: @Termineitor244

@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Apr 17, 2024
@Karol1223 Karol1223 marked this pull request as draft April 17, 2024 20:04
@Karol1223
Copy link
Contributor Author

Drafting since I forgot to make new birds spawn, will do that tomorrow

@Termineitor244
Copy link
Contributor

Hi! I'm currently traveling and in transit, so I can't really check the PR right now, but answering your question: Nop, I think it should be a remnant of bird taming in vanilla, all taming in the mod should first be with their chicks, and with the adults when appropriate for the individual species (city/domesticated species should offer no resistance, everything else I would need to read about their behaviors)

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Apr 19, 2024
@Karol1223 Karol1223 marked this pull request as ready for review April 21, 2024 13:43
@Maleclypse Maleclypse merged commit 008602a into CleverRaven:master Apr 21, 2024
22 of 31 checks passed
@Karol1223 Karol1223 deleted the brid branch April 22, 2024 12:44
@Karol1223 Karol1223 mentioned this pull request Aug 17, 2024
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: Tamable Wildlife Mods Issues related to mods or modding Spawn Creatures, items, vehicles, locations appearing on map
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants