why can’t clang-tidy just leave me alone?

CleverRaven · Oct 19, 2024 · 96aa876 · 96aa876
1 parent 1bce68d
commit 96aa876
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 2 deletions.
diff --git a/build-scripts/get_translation_characters.py b/build-scripts/get_translation_characters.py
@@ -10,9 +10,11 @@
 def main():
     print("// generated by get_translation_characters.py; example:")
     print("//   ./build-scripts/get_translation_characters.py en ar cs da de el es fr hu id is it ja ko nb nl pl pt ru sr tr uk_UA zh_Hans zh_Hant > src/cldr/imgui-glyph-ranges.cpp\n")
+    print("// NOLINTBEGIN(cata-static-declarations,readability-function-size)")
     try:
         for language in sys.argv[1:]:
             print_func(language)
+        print("// NOLINTEND(cata-static-declarations,readability-function-size)")
         return 0
     except KeyError as x:
         print(f"Unknown language code “{x.args[0]}”", file=sys.stderr)

diff --git a/src/cata_imgui.cpp b/src/cata_imgui.cpp
@@ -292,10 +292,12 @@ static int GetFallbackCharWidth( ImWchar c, const float scale )
     return fontwidth * mk_wcwidth( c ) * scale;
 }
 
+// NOLINTNEXTLINE(bugprone-suspicious-include)
 #include "cldr/imgui-glyph-ranges.cpp"
 
 static void AddGlyphRangesFromCLDR( ImFontGlyphRangesBuilder *b, const std::string &lang )
 {
+    // NOLINTBEGIN(bugprone-branch-clone)
     if( lang == "en" ) {
         AddGlyphRangesFromCLDRForEN( b );
     } else if( lang == "ar" ) {
@@ -347,6 +349,7 @@ static void AddGlyphRangesFromCLDR( ImFontGlyphRangesBuilder *b, const std::stri
     } else if( lang == "zh_TW" ) {
         AddGlyphRangesFromCLDRForZH_HANS( b );
     }
+    // NOLINTEND(bugprone-branch-clone)
 }
 
 #if defined(__clang__) || defined(__GNUC__)
@@ -358,6 +361,7 @@ static void AddGlyphRangesFromCLDR( ImFontGlyphRangesBuilder *b, const std::stri
 static void AddGlyphRangesMisc( UNUSED ImFontGlyphRangesBuilder *b,
                                 UNUSED const std::string &lang )
 {
+    // NOLINTNEXTLINE(modernize-avoid-c-arrays)
     static ImWchar superscripts[] = { 0x00B9, 0x00B9, 0x00B2, 0x00B3, 0x2070, 0x208E, 0x0000 };
     b->AddRanges( &superscripts[0] );
 }
@@ -389,10 +393,12 @@ static void check_font( const ImFont *font )
 {
     if( !font || !font->IsLoaded() ) {
         // we can’t use debugmsg or cata_fatal because they trigger a new ImGui frame
+        // NOLINTNEXTLINE(cert-err33-c)
         fprintf( stderr,
-                 "Failed to create font atlas! Make sure that your chosen font "
-                 "exists, can be read, and has glyphs for your chosen "
+                 "Failed to create font atlas!  Make sure that your chosen "
+                 "font exists, can be read, and has glyphs for your chosen "
                  "language.\n" );
+        // NOLINTNEXTLINE(cata-assert)
         std::abort();
     }
 }

diff --git a/src/cldr/imgui-glyph-ranges.cpp b/src/cldr/imgui-glyph-ranges.cpp
@@ -1,6 +1,7 @@
 // generated by get_translation_characters.py; example:
 //   ./build-scripts/get_translation_characters.py en ar cs da de el es fr hu id is it ja ko nb nl pl pt ru sr tr uk_UA zh_Hans zh_Hant > src/cldr/imgui-glyph-ranges.cpp
 
+// NOLINTBEGIN(cata-static-declarations,readability-function-size)
 static void AddGlyphRangesFromCLDRForEN( ImFontGlyphRangesBuilder *b )
 {
     b->AddChar( 0x61 );
@@ -41531,3 +41532,4 @@ static void AddGlyphRangesFromCLDRForZH_HANT( ImFontGlyphRangesBuilder *b )
     b->AddChar( 0xff5d );
 }
 
+// NOLINTEND(cata-static-declarations,readability-function-size)