Merge pull request #76574 from akrieger/no_duping_allowed

Don't unnecessarily copy items in a tight loop in get_uncraft_components
CleverRaven · Sep 21, 2024 · 6805e26 · 6805e26
2 parents e66affb + 7c286c7
commit 6805e26
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/src/item.cpp b/src/item.cpp
@@ -14908,8 +14908,7 @@ std::vector<item_comp> item::get_uncraft_components() const
                 if( component.has_flag( flag_UNRECOVERABLE ) ) {
                     continue;
                 }
-                // NOLINTNEXTLINE(clang-analyzer-cplusplus.NewDeleteLeaks)
-                auto iter = std::find_if( ret.begin(), ret.end(), [component]( item_comp & obj ) {
+                auto iter = std::find_if( ret.begin(), ret.end(), [&component]( item_comp & obj ) {
                     return obj.type == component.typeId();
                 } );