Check and write version.h only if we have a version

CleverRaven · Feb 6, 2024 · 253168d · 253168d
1 parent 1f2b9f5
commit 253168d
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 8 deletions.
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -60,6 +60,7 @@ execute_process(COMMAND ${CMAKE_COMMAND}
     -DGIT_BINARY=${GIT_BINARY}
     -P ${CMAKE_SOURCE_DIR}/src/version.cmake
     ERROR_VARIABLE GIT_VERSION
+    ERROR_STRIP_TRAILING_WHITESPACE
     WORKING_DIRECTORY ${CMAKE_SOURCE_DIR}
 )
 

diff --git a/src/version.cmake b/src/version.cmake
@@ -22,14 +22,15 @@ if("${GIT_VERSION}" MATCHES "GIT-NOTFOUND")
     return()
 endif()
 
-string(REPLACE "-NOTFOUND" "" GIT_VERSION ${GIT_VERSION})
-
-file(READ  ${CMAKE_SOURCE_DIR}/src/version.h VERSION_H)
-string(REGEX MATCH "#define VERSION \"(.+)\"" VERSION_H "${VERSION_H}")
-
-if(NOT GIT_VERSION STREQUAL VERSION_H)
-    file(WRITE ${CMAKE_SOURCE_DIR}/src/version.h
-            "// NOLINT(cata-header-guard)\n\#define VERSION \"${GIT_VERSION}\"\n")
+if(GIT_VERSION)
+    string(REPLACE "-NOTFOUND" "" GIT_VERSION ${GIT_VERSION})
+    file(READ  ${CMAKE_SOURCE_DIR}/src/version.h VERSION_H)
+    string(REGEX MATCH "#define VERSION \"(.+)\"" VERSION_H "${VERSION_H}")
+
+    if(NOT GIT_VERSION STREQUAL VERSION_H)
+        file(WRITE ${CMAKE_SOURCE_DIR}/src/version.h
+                "// NOLINT(cata-header-guard)\n\#define VERSION \"${GIT_VERSION}\"\n")
+    endif()
 endif()
 
 # get_git_head_revision() does not work with worktrees in Windows