Clang-tidy 17

Migrate NPC rules to a new, dedicated imgui menu #78061

Sign in to view logs

Annotations

8 errors

src/npctalk_rules.cpp#L91

parameter 'initial_string' is passed by value and only copied once; consider moving it to avoid unnecessary copies [performance-unnecessary-value-param,-warnings-as-errors]

src/npctalk_rules.cpp#L110

insufficient spaces at this location. 2 required, but only 1 found. [cata-text-style,-warnings-as-errors]

src/npctalk_rules.cpp#L139

loop variable is copied but only used as const reference; consider making it a const reference [performance-for-range-copy,-warnings-as-errors]

src/npctalk_rules.cpp#L190

loop variable is copied but only used as const reference; consider making it a const reference [performance-for-range-copy,-warnings-as-errors]

src/npctalk_rules.cpp#L226

loop variable is copied but only used as const reference; consider making it a const reference [performance-for-range-copy,-warnings-as-errors]

src/npctalk_rules.cpp#L264

loop variable is copied but only used as const reference; consider making it a const reference [performance-for-range-copy,-warnings-as-errors]

src/npctalk_rules.cpp#L297

loop variable is copied but only used as const reference; consider making it a const reference [performance-for-range-copy,-warnings-as-errors]

Process completed with exit code 123.

This job failed