Unhardcode and limbify attack vectors take two: Electric boogaloo #76409
Annotations
8 errors
|
run clang-tidy:
src/martialarts.cpp#L39
Variable 'attack_vector_null' declared but not used. [cata-unused-statics,-warnings-as-errors]
|
|
run clang-tidy:
src/martialarts.cpp#L39
Declaration of string_id 'attack_vector_null' should be named 'wip_attack_vector_null'. [cata-static-string_id-constants,-warnings-as-errors]
|
|
run clang-tidy:
src/martialarts.cpp#L1466
Value stored to 'found' is never read [clang-analyzer-deadcode.DeadStores,-warnings-as-errors]
|
|
run clang-tidy:
src/martialarts.cpp#L1473
the type of the loop variable 'bp' is different from the one returned by the iterator and generates an implicit conversion; you can either change the type to the matching one ('const string_id<body_part_type> &' but 'const auto&' is always a valid option) or remove the reference to make it explicit that you are creating a new value [performance-implicit-conversion-in-loop,-warnings-as-errors]
|
|
run clang-tidy:
src/martialarts.cpp#L1473
loop variable 'bp' of type 'const bodypart_id &' (aka 'const int_id<body_part_type> &') binds to a temporary constructed from type 'reference' (aka 'const string_id<body_part_type> &') [clang-diagnostic-range-loop-construct,-warnings-as-errors]
|
|
run clang-tidy:
src/melee.cpp#L1660
Value stored to 'wip' during its initialization is never read [clang-analyzer-deadcode.DeadStores,-warnings-as-errors]
|
|
run clang-tidy:
src/melee.cpp#L1660
unused variable 'wip' [clang-diagnostic-unused-variable,-warnings-as-errors]
|
|
run clang-tidy
Process completed with exit code 123.
|
Loading