Skip to content

Jsonify water boiling and other temperature effects on the item #83683

Jsonify water boiling and other temperature effects on the item

Jsonify water boiling and other temperature effects on the item #83683

Triggered via pull request December 14, 2024 12:29
@moxianmoxian
synchronize #78562
moxian:boil
Status Failure
Total duration 4h 11m 5s
Artifacts

clang-tidy.yml

on: pull_request
skip-duplicates
5s
skip-duplicates
Matrix: build
Fit to window
Zoom out
Zoom in

Annotations

5 errors and 1 warning
build (src): src/item_factory.cpp#L2694
Parameter 'src' of 'load_temperature_effects' can be std::string_view. [cata-use-string_view,-warnings-as-errors]
build (src): src/item_factory.cpp#L2694
unused parameter 'src' [clang-diagnostic-unused-parameter,-warnings-as-errors]
build (src): src/item_factory.cpp#L2694
parameter 'src' is unused [misc-unused-parameters,-warnings-as-errors]
build (src): src/item_factory.cpp#L2700
the type of the loop variable 'tejo' is different from the one returned by the iterator and generates an implicit conversion; you can either change the type to the matching one ('const JsonValue &' but 'const auto&' is always a valid option) or remove the reference to make it explicit that you are creating a new value [performance-implicit-conversion-in-loop,-warnings-as-errors]
build (src)
Process completed with exit code 123.
skip-duplicates
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636