Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc Improvements #293

Merged
merged 35 commits into from
Sep 4, 2024
Merged

Misc Improvements #293

merged 35 commits into from
Sep 4, 2024

Conversation

longemen3000
Copy link
Member

  • adds ReidIdeal model of R1234ze(E) (Adding fluid R1234ze(E) - ReidIdeal #292)
  • Refactors critical extrapolation methods into functions: new functions: critical_psat_extrapolation, critical_tsat_extrapolation and critical_vsat_extrapolation (not exported). It also adds a CritExtrapolationSaturation saturation method that uses those extrapolations to give an (accurate enough) saturation results for points near the critical point.
  • improves some superancillary initial points to use extrapolation in case the superanc is outside the domain
  • renamed some internal functions for bubbledew saturation into extended_saturation_pressure and extended_saturation_temperature. as their name implies, they are equivalent to their normal names, but extrapolate beyond the critical point (via the extrapolation functions mentioned before)
  • improved initial point for cubics (mentioned in dew temperature abnormality with water?  #290)
  • adds some functions used in isochoric thermodynamic formulation: one key result is that: Ψ(model,T,ρᵢ) = sum(ρᵢ)*R*T*a_eos(model,1.0,T,ρᵢ). this allows to evaluate Ψ-related functions without extra allocations, and we can switch between isochoric and VTn formulations easily.

Copy link

codecov bot commented Sep 4, 2024

Codecov Report

Attention: Patch coverage is 34.22819% with 196 lines in your changes missing coverage. Please review.

Project coverage is 77.37%. Comparing base (640f7f8) to head (45cf149).
Report is 36 commits behind head on master.

Files with missing lines Patch % Lines
src/methods/isochoric.jl 0.00% 74 Missing ⚠️
src/methods/initial_guess.jl 26.66% 33 Missing ⚠️
...ds/property_solvers/multicomponent/bubble_point.jl 55.55% 28 Missing ⚠️
...rs/singlecomponent/saturation/CritExtrapolation.jl 0.00% 22 Missing ⚠️
ext/ClapeyronSuperancillaries.jl 5.55% 17 Missing ⚠️
src/base/errors.jl 37.50% 5 Missing ⚠️
...thods/property_solvers/multicomponent/dew_point.jl 61.53% 5 Missing ⚠️
..._solvers/singlecomponent/saturation/IsoFugacity.jl 80.00% 3 Missing ⚠️
src/methods/stability.jl 0.00% 3 Missing ⚠️
src/utils/misc.jl 25.00% 3 Missing ⚠️
... and 3 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #293      +/-   ##
==========================================
- Coverage   77.88%   77.37%   -0.52%     
==========================================
  Files         317      319       +2     
  Lines       23638    23847     +209     
==========================================
+ Hits        18411    18452      +41     
- Misses       5227     5395     +168     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@longemen3000 longemen3000 merged commit e527fe1 into master Sep 4, 2024
17 of 24 checks passed
@longemen3000 longemen3000 deleted the eos_super_anc_improvements branch September 26, 2024 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant