tc_build: kernel: Silence new ruff warning (SIM115) #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the same warning that we already disable for pylint, for the
reasons outlined in the comment block above this.
tc_build/kernel.py:82:33: SIM115 Use a context manager for opening files
|
80 | # always cleaned up.
81 | # pylint: disable-next=consider-using-with
82 | kconfig_allconfig = NamedTemporaryFile(dir=self.folders.build)
| ^^^^^^^^^^^^^^^^^^ SIM115
83 |
84 | configs_to_disable = ['DRM_WERROR', 'WERROR']
|
Found 1 error.
Signed-off-by: Nathan Chancellor <[email protected]>
msfjarvis
approved these changes
Oct 21, 2024
onettboots
pushed a commit
to onettboots/boolx-clang-build
that referenced
this pull request
Oct 25, 2024
…ruff-warning tc_build: kernel: Silence new ruff warning (SIM115) Signed-off-by: onettboots <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the same warning that we already disable for
pylint, for the reasons outlined in the comment block above this.