-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dataset Management API Support #83
base: master
Are you sure you want to change the base?
Dataset Management API Support #83
Conversation
General : Run FxCop on this code base (or some more modern analog) File : SODA.Tests/SodcaClientTests.cs
File : README.md
File : SODA/PipelineJob.cs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here are some suggestions. probably the most valuable will be to run static code analysis tools and style tools on this project.
/// <exception cref="System.ArgumentOutOfRangeException">Thrown if the specified <paramref name="resourceId"/> does not match the Socrata 4x4 pattern.</exception> | ||
public Revision CreateRevision(string method, string resourceId, string permission = "private") | ||
{ | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
extra line
@PeterAustinMoore this is a tremendous effort, thank you for submitting the PR! I haven't had the time to fully dig in and review yet, but I wanted to let you know its on our radar. One thing that would greatly help the review is if you could I can't promise when we'll get to this, but we are definitely interested in folding in the functionality. Stay tuned! |
This is my first foray into C# and .NET, so any pointers/feedback greatly appreciated. I tried to set up the building blocks based off of https://github.com/socrata/socrata-py
What it adds:
What it removes:
What it could do in the future: