vm: fix order when pushing dictionaries with ScriptBuilder (#300)

CityOfZion · Jan 12, 2024 · 3c52009 · 3c52009
1 parent c238d68
commit 3c52009
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/neo3/vm.py b/neo3/vm.py
@@ -402,7 +402,7 @@ def emit_push(self, value) -> ScriptBuilder:
             self.emit(OpCode.PACK)
             return self
         elif isinstance(value, dict):
-            for k, v in value.items():
+            for k, v in reversed(value.items()):
                 # This restriction exists on the VM side where keys to a 'Map' may only be of 'PrimitiveType'
                 if not isinstance(
                     k, (int, str, bool, bytes, serialization.ISerializable)

diff --git a/tests/test_vm.py b/tests/test_vm.py
@@ -143,13 +143,13 @@ def test_emit_push_dict(self):
 
         sb = vm.ScriptBuilder()
         sb.emit_push(data)
-        expected = "007b0c016101c8010c016212be"
+        expected = "01c8010c0162007b0c016112be"
         self.assertEqual(expected, sb.to_array().hex())
 
         data = {b"\x01": 1, b"\x02": 2}
         sb = vm.ScriptBuilder()
         sb.emit_push(data)
-        expected = "110c0101120c010212be"
+        expected = "120c0102110c010112be"
         self.assertEqual(expected, sb.to_array().hex())
 
         # test invalid key type