Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rejected occurrences tab sorting and pagination #1558

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

vincit-matu
Copy link
Contributor

@vincit-matu vincit-matu commented Dec 3, 2024

🛠️ Changelog

  • Fixes the sorting and pagination of the rejected occurrences listing, shown in a tab under a handled application round which resulted in rejected occurrences

🧪 Test plan

  • Sorting by unit name and reservation unit name should now work (along with all the other sorting options)
  • Check that the pagination works:
    • If you have an application round which has resulted in over 50 rejected occurrences you can test it by viewing that application round
    • Otherwise: you need to have an application round which has resulted in at least a few rejected occurrences to be able to test this. To avoid having to create over 50 rejected occurrences you can use any smaller value instead of LIST_PAGE_SIZE on line 42 in apps/admin-ui/src/spa/application-rounds/[id]/review/RejectedOccurrencesDataLoader.tsx. This defines the page size to be used in the listing, making testing pagination possible even with a smaller total count.

🎫 Tickets

  • TILA-3446

@vincit-matu vincit-matu requested a review from joonatank December 3, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants