Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dropdown options for client #1553

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

vincit-matu
Copy link
Contributor

@vincit-matu vincit-matu commented Nov 28, 2024

🛠️ Changelog

  • Uses the non-paged endpoints for units and equipment filter options
  • Fixes the sorting of options on the search page filters in client view as follows:
    • purpose: by rank
    • unit: by name
    • equipments: by equipments category rank
    • reservation type: by rank
  • Sorts the reservation purpose options by rank, when making a reservation on client side

🧪 Test plan

  • Check corresponding name/rank value from Django, and see that the options in respective select-inputs are in the same order on the search page
  • Do the same for reservation purposes

🎫 Tickets

  • TILA-3541
  • TILA-3553

@vincit-matu vincit-matu changed the title fix: search filter sorting and update use the non paged endpoints Order dropdown options and use the non-paged endpoints for client Nov 28, 2024
@vincit-matu vincit-matu changed the title Order dropdown options and use the non-paged endpoints for client Fix dropdown options for client Nov 28, 2024
Copy link
Contributor

@joonatank joonatank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing unit query params (seasonal / single) need to be checked

apps/ui/hooks/useOptions.ts Outdated Show resolved Hide resolved
apps/ui/hooks/useOptions.ts Show resolved Hide resolved
apps/ui/modules/search.ts Outdated Show resolved Hide resolved
@vincit-matu vincit-matu force-pushed the search-filters-fixes-client branch from d5880f3 to 3bc6218 Compare December 3, 2024 18:07
@vincit-matu vincit-matu requested a review from joonatank December 3, 2024 18:11
@joonatank
Copy link
Contributor

can't be merged before the query params are added to backend and the query is changed

@vincit-matu vincit-matu force-pushed the search-filters-fixes-client branch 2 times, most recently from 782431a to 7770bf4 Compare December 17, 2024 12:58
@vincit-matu vincit-matu force-pushed the search-filters-fixes-client branch from 7770bf4 to 37f5aa6 Compare December 17, 2024 13:06
Copy link
Contributor

@joonatank joonatank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants