-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix dropdown options for client #1553
Open
vincit-matu
wants to merge
1
commit into
main
Choose a base branch
from
search-filters-fixes-client
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincit-matu
changed the title
fix: search filter sorting and update use the non paged endpoints
Order dropdown options and use the non-paged endpoints for client
Nov 28, 2024
vincit-matu
changed the title
Order dropdown options and use the non-paged endpoints for client
Fix dropdown options for client
Nov 28, 2024
joonatank
requested changes
Dec 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing unit query params (seasonal / single) need to be checked
vincit-matu
force-pushed
the
search-filters-fixes-client
branch
from
December 3, 2024 18:07
d5880f3
to
3bc6218
Compare
can't be merged before the query params are added to backend and the query is changed |
vincit-matu
force-pushed
the
search-filters-fixes-client
branch
2 times, most recently
from
December 17, 2024 12:58
782431a
to
7770bf4
Compare
vincit-matu
force-pushed
the
search-filters-fixes-client
branch
from
December 17, 2024 13:06
7770bf4
to
37f5aa6
Compare
joonatank
approved these changes
Dec 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠️ Changelog
🧪 Test plan
🎫 Tickets